Skip to content

Conversation

@vignanv
Copy link
Contributor

@vignanv vignanv commented Nov 12, 2025

Summary

Enhances the Oracle provider’s OracleHook to support additional connection parameters available in the python-oracledb driver.

Details

  • Added support for the following parameters in connection configuration:
    • wallet_location
    • wallet_password
    • ssl_server_cert_dn
    • ssl_server_dn_match
    • cclass
    • pool_name
  • Added a new unit test test test_get_conn_with_various_params to validate these parameters are correctly passed to oracledb.connect().

Testing

  • Verified with pytest locally, new parameters propagate correctly to oracledb.connect().
  • All existing Oracle provider tests pass.

Notes

  • Added a TODO to migrate mode and purity handling to enums (oracledb.AuthMode, oracledb.Purity) once Airflow raises the minimum python-oracledb requirement to 2.3+.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 12, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Nov 17, 2025

Errors :(

@potiuk
Copy link
Member

potiuk commented Nov 18, 2025

Static check to fix still prek install and prek run in general should help to solve those.

@vignanv
Copy link
Contributor Author

vignanv commented Nov 20, 2025

@potiuk,
Thanks for the review and help!
All checks are passing now and the PR is ready for merge.
Please let me know if anything else is needed.

@amoghrajesh amoghrajesh merged commit 9b32b56 into apache:main Nov 25, 2025
82 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 25, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants