Configure uvicorn timeout_worker_healthcheck
#57731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlieven
force-pushed
the
api/uvicorn-healthcheck
branch
from
d828d10 to
9aa71c0
Compare
Contributor
Author
|
@potiuk You confirmed this issue in september (#52270 (comment)), any chance of getting a review for this PR? |
potiuk
approved these changes
Nov 5, 2025
Member
|
Lgtm but maybe also @pierrejeambrun and @ashb can take a look - I mostly tangentially worked on API server and way how we integrate with unicorn - it does look promising though |
pierrejeambrun
approved these changes
Nov 5, 2025
ashb
added
the
backport-to-v3-1-test
github-actions bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
…r-timeout CLI option (#57731) - Set the minimum version for uvicorn to 0.37.0, so that this setting can be provided. - Add "timeout_worker_healthcheck" to the uvicorn_kwargs, and set it to the worker_timeout value that is already used to configure the "timeout_keep_alive" and "timeout_graceful_shutdown" settings. This increases the timeout value from 5 seconds to 120 seconds by default. This increase is the same as for the "timeout_keep_alive" setting. (cherry picked from commit e98dd9f) Co-authored-by: vlieven <verswyvel.lieven@gmail.com>
Backport successfully created: v3-1-test
|
ashb
pushed a commit
that referenced
this pull request
Nov 5, 2025
…r-timeout CLI option (#57731) (#57854) - Set the minimum version for uvicorn to 0.37.0, so that this setting can be provided. - Add "timeout_worker_healthcheck" to the uvicorn_kwargs, and set it to the worker_timeout value that is already used to configure the "timeout_keep_alive" and "timeout_graceful_shutdown" settings. This increases the timeout value from 5 seconds to 120 seconds by default. This increase is the same as for the "timeout_keep_alive" setting. (cherry picked from commit e98dd9f) Co-authored-by: vlieven <verswyvel.lieven@gmail.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 10, 2025
…r-timeout CLI option (#57731) (#57854) - Set the minimum version for uvicorn to 0.37.0, so that this setting can be provided. - Add "timeout_worker_healthcheck" to the uvicorn_kwargs, and set it to the worker_timeout value that is already used to configure the "timeout_keep_alive" and "timeout_graceful_shutdown" settings. This increases the timeout value from 5 seconds to 120 seconds by default. This increase is the same as for the "timeout_keep_alive" setting. (cherry picked from commit e98dd9f) Co-authored-by: vlieven <verswyvel.lieven@gmail.com>
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
…I option (apache#57731) - Set the minimum version for uvicorn to 0.37.0, so that this setting can be provided. - Add "timeout_worker_healthcheck" to the uvicorn_kwargs, and set it to the worker_timeout value that is already used to configure the "timeout_keep_alive" and "timeout_graceful_shutdown" settings. This increases the timeout value from 5 seconds to 120 seconds by default. This increase is the same as for the "timeout_keep_alive" setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed the child process death issue, also reported in #52270 on our kubernetes-based deployment. The issue was partly mitigated by #55707, but the root cause in uvicorn was not fixed at that time (related: Kludex/uvicorn#2397, stackabletech/airflow-operator#641).
Essentially, uvicorn had a healthcheck timeout that was set too low, and could not be configured.
Fortunately, as of release 0.37.0, uvicorn allows configuring this timeout value (PR: Kludex/uvicorn#2711).
This PR does two things:
worker_timeoutvalue that is already used to configure the "timeout_keep_alive" and "timeout_graceful_shutdown" settings. This increases the timeout value from 5 seconds to 120 seconds by default. This increase is the same as for the "timeout_keep_alive" setting.