-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Reduce default API server workers to 1 #55707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
2 tasks
vatsrahul1001
approved these changes
Sep 16, 2025
vatsrahul1001
approved these changes
Sep 16, 2025
Member
Author
|
I should say, I think this is a safer default and (in my testing at least) avoids the timeout problems we've seen in #52270 even in a cpu constrained environment. My scale testing shows this change is roughly equivalent with 1 core, and a lot faster with half a core (especially for heavier requests). |
pierrejeambrun
approved these changes
Sep 16, 2025
kaxil
approved these changes
Sep 16, 2025
vincbeck
approved these changes
Sep 16, 2025
kaxil
pushed a commit
that referenced
this pull request
Sep 16, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now. (cherry picked from commit 87fc469)
suman-himanshu
pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
dstandish
pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 19, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now. (cherry picked from commit 87fc469)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server. With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default number of API server workers from 4 to 1 and add guidance to deploy multiple API servers for scaling instead of increasing workers per server.
With FastAPI, sync code runs in an external thread pool, making multiple workers within a single api server less necessary than it was in our flask days. And with uvicorns new spawn behavior instead of fork, it means no shared copy-on-write memory between workers, so it's better to scale horizontally now.
Closes #52270