Fix DAG bundle retrieval from S3 #57178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case where DAGs stored in S3 are not retrieved.
bucket.objectsreturns prefix objects:The
dags/object should not be copied as regular files.Current unit tests do not include the prefix object so the tests passes. However, it does not work when using actual S3 service.
You can reproduce the failure by adding the prefix object in the unit test.
fixes: #57176
Note that the delimiter is hardcoded as
/. This is technically not true for all bucket uses. However, since the rest of the code also hardcode delimiter as/, I've left it as-is.