Skip to content

Conversation

@gkirchou
Copy link

@gkirchou gkirchou commented Sep 28, 2025

When Asset or Metadata objects are created with extra dictionaries containing numpy types (e.g., np.int64, np.float64, np.ndarray), downstream JSON serialization can fail, as these types are not directly
serializable to JSON. This issue can arise when metadata is passed via TaskOutlets.

This change introduces automatic normalization of the extra metadata upon Asset and Metadata instantiation. It recursively converts numpy integer, float, boolean, array, and complex types into standard Python types (int, float, bool, list, dict) to ensure JSON serializability.

closes: #53474


Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 28, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@gkirchou
Copy link
Author

gkirchou commented Oct 4, 2025

Marked this read to review to proceed the discussion - #53474 (comment)

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to hear @amoghrajesh and @ashb's thoughts on handling NumPy as a special case here. This should be able to resolve the issue. However, what happens if we encounter an issue with the next library? How do we decide which libraries we should support?

If we were to doing something similar, https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/serialization/serialized_objects.py is probably a better place instead?

@Lee-W Lee-W added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Oct 27, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 18, 2025
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdk backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when emitting Asset Metadata if value in extra is of type np.float64

6 participants