-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add asset_helpers.py with tests and support it in asset definitions. #56175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Marked this read to review to proceed the discussion - #53474 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to hear @amoghrajesh and @ashb's thoughts on handling NumPy as a special case here. This should be able to resolve the issue. However, what happens if we encounter an issue with the next library? How do we decide which libraries we should support?
If we were to doing something similar, https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/serialization/serialized_objects.py is probably a better place instead?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
When
AssetorMetadataobjects are created withextradictionaries containing numpy types (e.g.,np.int64,np.float64,np.ndarray), downstream JSON serialization can fail, as these types are not directlyserializable to JSON. This issue can arise when metadata is passed via
TaskOutlets.This change introduces automatic normalization of the
extrametadata uponAssetandMetadatainstantiation. It recursively converts numpy integer, float, boolean, array, and complex types into standard Python types (int, float, bool, list, dict) to ensure JSON serializability.closes: #53474
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.