Modal Confirmation Dialog before rerun of tasks in 'Running', 'Restarting', and 'Up_for_retry' states. #55660

kncatalan · 2025-09-15T04:56:41Z

Why

This is a pull request based on the raised issue #54379.
Summary of the issue:
A UI implementation of a workaround that seeks to prevent duplicate runs of the same task instance by adding another confirmation pop-up before re-running tasks in a running, restarting, or up-for-retry state.

What

The pop-up confirmation works by checking the state of the task instance when requesting a rerun. If the task instance is in a running, restarting, or up-for-retry state, then it will display a second confirmation pop-up. Otherwise, it will not show the second pop-up confirmation dialog.

Here is a sample of the modal confirmation dialog when a task is running:

chrome_tBE1fBd92x.mp4

Here is a sample where the modal will not display when trying to re-run a task in other states other than running, restarting, and up-for-retry:

chrome_YoFXuWnYl3.mp4

Here is another, longer sample that simulates 2 users trying to re-run the same task:

axhSsOHNIc.mp4

boring-cyborg · 2025-09-15T04:56:43Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

bbovenzi · 2025-09-15T21:00:44Z

The backend should return an error on an erroneous second clear action. Let's not do a UI-only bandaid solution.

pierrejeambrun

Cool, thanks for the PR.

As mentioned by Brent, we can do that on the server side.

We can add a flag to the server, default behavior stays the same. (we don't want to break the API backward compat), and the front-end set the appropriate flag value to prevent reclearing if dag is already runing.

...ore/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceConfirmationDialog.tsx

pierrejeambrun · 2025-09-17T12:56:23Z

Also we should probably do something similar for Runs.

…nning, up_for_retry, or restarting state.

…n confirmation dialogue.

…and ui still not communicating. MIGHT revert to previous commit.

…that will not run the instance until the instance is not running.

jason810496

Nice! Thanks for the PR!
The tests are required for the Airflow Core change, thanks!

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py

airflow-core/src/airflow/models/taskinstance.py

…o router. Followed suggestion about attribute access.

…by default.

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py

…712.

… value error

…nningTasks in dags.json in the en locale.

pierrejeambrun

Thanks, a few more comments.

airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceDialog.tsx

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py

airflow-core/src/airflow/api_fastapi/core_api/datamodels/task_instances.py

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py

…ent_running_tasks' addition to ti, instead, it is passed as a parameter in clearTaskInstance.

pierrejeambrun

Looking good. A few last comments and we should be good to merge.

airflow-core/src/airflow/models/taskinstance.py

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py

…Error code 400 is still being raised in the router.

…f trying to clear a running task.

jason810496

Thanks for the update and please not be hesitate to resolve the addressed comments.

The test for airflow-core/src/airflow/models/taskinstance.py change is required.

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py

kncatalan · 2025-10-03T01:33:25Z

Hello,
This comment will be an update for this PR

This is how the PR currently looks like:

chrome_VkmgN56gJw.mp4

Since the current state of this PR is a little bit different from the expected outcome stated in the PR description, I will make a new PR that uses this PR's code. The will be new PR's goal will still be the same however in the description, instead of a modal pop-up, it will be a checkbox instead.

bbovenzi · 2025-10-09T18:15:44Z

So should we close this PR in favor of the other one?

kncatalan · 2025-10-14T06:48:22Z

So should we close this PR in favor of the other one?

If possible, yes.

pierrejeambrun · 2025-10-14T13:29:48Z

Closing as requested @KlarenceNicolasCatalan

kncatalan requested review from bbovenzi, pierrejeambrun and ryanahamilton as code owners September 15, 2025 04:56

kncatalan requested review from jscheffl and shubhamraj-git as code owners September 15, 2025 04:56

boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Sep 15, 2025

pierrejeambrun reviewed Sep 17, 2025

View reviewed changes

...ore/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceConfirmationDialog.tsx Outdated Show resolved Hide resolved

pierrejeambrun added this to the Airflow 3.1.1 milestone Sep 17, 2025

kncatalan added 2 commits September 18, 2025 07:53

Added a confirm dialog modal that appears only when the task is in ru…

e9e45a2

…nning, up_for_retry, or restarting state.

Removed unnecessary comments

fb4e814

kncatalan force-pushed the add-modal-confirmation-dialog branch from 7f8daa2 to fb4e814 Compare September 17, 2025 23:53

kncatalan added 2 commits September 18, 2025 08:32

Added clearTask texts in dags.json in the EN locale. Used translate i…

a6606a5

…n confirmation dialogue.

(NON-WORKING/ Experimental) added a flag in taskinstance.py. backend …

28ccb4a

…and ui still not communicating. MIGHT revert to previous commit.

kncatalan requested review from XD-DENG, ashb, bugraoz93, ephraimbuddy, jason810496 and rawwar as code owners September 18, 2025 06:24

kncatalan added 2 commits September 19, 2025 13:01

(EXPERIMENTAL) Removed the confirm pop-up and replaced with checkbox …

68cfb78

…that will not run the instance until the instance is not running.

Added mirgin-right auto for the checkbox

4dc0cde

jason810496 reviewed Sep 19, 2025

View reviewed changes

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py Outdated Show resolved Hide resolved

airflow-core/src/airflow/models/taskinstance.py Outdated Show resolved Hide resolved

airflow-core/src/airflow/models/taskinstance.py Outdated Show resolved Hide resolved

kncatalan added 2 commits September 22, 2025 10:39

Change isRunning to task_confirmed_running. Moved the HTTPException t…

19bca7c

…o router. Followed suggestion about attribute access.

Made the checkbox checked on default. is_running_message set to true …

0571c4c

…by default.

jason810496 reviewed Sep 23, 2025

View reviewed changes

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py Outdated Show resolved Hide resolved

kncatalan added 2 commits September 23, 2025 10:11

Added the code 400 to line 688.

cebfb32

Cleaned up the code and attempted to adress the error in the tests, e…

dd74fb3

…712.

kncatalan added 2 commits September 26, 2025 10:36

Made sure the date variable is not null and changed the string in the…

37e0249

… value error

Changed the hardcoded english into an i18n translate. Added preventRu…

96e3910

…nningTasks in dags.json in the en locale.

pierrejeambrun reviewed Sep 26, 2025

View reviewed changes

Renamed the is_running_message to prevent_running_tasks. Removed prev…

fdcaeb7

…ent_running_tasks' addition to ti, instead, it is passed as a parameter in clearTaskInstance.

pierrejeambrun reviewed Oct 1, 2025

View reviewed changes

kncatalan added 4 commits October 2, 2025 08:09

Added a custom airflow exception for clearing running task instance. …

e096164

…Error code 400 is still being raised in the router.

Added retry 0 in use clearTaskInstances.

4a04425

Added a conditional for error toast that states the task is running i…

7230e35

…f trying to clear a running task.

added check for null in error.detail

a86bc34

jason810496 reviewed Oct 2, 2025

View reviewed changes

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py Outdated Show resolved Hide resolved

kncatalan and others added 3 commits October 2, 2025 13:28

removed unnecessary imports in task_instances.py

3b6eade

made the prevent_running_task optional to pass checks

e0687d1

Merge branch 'main' into add-modal-confirmation-dialog

c337e13

kncatalan mentioned this pull request Oct 3, 2025

Checkbox before clear task confirmation to prevent rerun of tasks in 'Running' states. #56351

Merged

pierrejeambrun closed this Oct 14, 2025

kaxil removed this from the Airflow 3.1.1 milestone Oct 21, 2025

Modal Confirmation Dialog before rerun of tasks in 'Running', 'Restarting', and 'Up_for_retry' states. #55660

Modal Confirmation Dialog before rerun of tasks in 'Running', 'Restarting', and 'Up_for_retry' states. #55660

Uh oh!

Conversation

kncatalan commented Sep 15, 2025

Why

What

Uh oh!

boring-cyborg bot commented Sep 15, 2025

Uh oh!

bbovenzi commented Sep 15, 2025

Uh oh!

pierrejeambrun left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pierrejeambrun commented Sep 17, 2025

Uh oh!

jason810496 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jason810496 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kncatalan commented Oct 3, 2025

Uh oh!

bbovenzi commented Oct 9, 2025

Uh oh!

kncatalan commented Oct 14, 2025

Uh oh!

pierrejeambrun commented Oct 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pierrejeambrun left a comment •

edited

Loading