fix(hitl): guard empty options or chosen_options when writing response #54355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:airflow-ctl
area:API
Lee-W
force-pushed
the
guard-hitl-empty-option
branch
from
16e2c5b to
d02b266
Compare
Lee-W
requested review from
amoghrajesh,
ashb,
bbovenzi,
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
kaxil,
pierrejeambrun,
potiuk,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
Lee-W
force-pushed
the
guard-hitl-empty-option
branch
from
d02b266 to
9d827f4
Compare
Lee-W
force-pushed
the
guard-hitl-empty-option
branch
from
9d827f4 to
470d5c5
Compare
jason810496
approved these changes
Aug 12, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Nice! LGTM, nice to see more validations at API data model level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Adding a
HITLDetailwithoptionsand updating aHITLDetailwith emptychosen_optionsshould not be allowed.close: #54265
What
validate_optionsmethod forHITLOperatorto checkoptionsmin_length=1restriction to insert or update that containschosen_options^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.