Fix Helm Chart Linting Return Code Check #54013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pre-commit hook for Helm linting incorrectly referenced res_setup.returncode instead of result.returncode when checking for linting errors. This change corrects the variable reference to properly handle errors from the Helm lint command. - Updated error check to use result.returncode
HsiuChuanHsu
requested review from
ashb,
gopidesupavan and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
jedcunningham
approved these changes
Aug 1, 2025
jedcunningham
removed
the
backport-to-v3-1-test
Contributor
Author
|
Thanks for the review! |
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
…54013) The pre-commit hook for Helm linting incorrectly referenced res_setup.returncode instead of result.returncode when checking for linting errors. This change corrects the variable reference to properly handle errors from the Helm lint command. - Updated error check to use result.returncode
fweilun
pushed a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
…54013) The pre-commit hook for Helm linting incorrectly referenced res_setup.returncode instead of result.returncode when checking for linting errors. This change corrects the variable reference to properly handle errors from the Helm lint command. - Updated error check to use result.returncode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect return code check in
lint_helm.pypre-commit script, ensuring Helm linting errors are properly detected.res_setup.returncode) checked.result.returncodefor Helm lint command.Changes
scripts/ci/pre_commit/lint_helm.py:-- Replaced
res_setup.returncodewithresult.returncodein lint error check.Related PR
Replace break function in
pod-launcher-rolebinding.yaml#49219^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.