Replace break function in pod-launcher-rolebinding.yaml
#49219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guan404ming
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
guan404ming
changed the title
pod-launcher-rolebinding templatepod-launcher-rolebinding.yaml
romsharon98
approved these changes
Apr 14, 2025
Contributor
|
Is there a way to test this to avoid regression? |
Member
Author
|
These are a few of my current thoughts:
Do you have any hints or suggestions? |
guan404ming
force-pushed
the
fix-helm
branch
3 times, most recently
from
08e5ec6 to
0b3bac3
Compare
Contributor
Don't we have a test that tries to upgrade the helm chart version? Such test would have caught the issue as the upgrade would fail |
Member
Author
|
It seems like there's currently no test for this, but I feel like my Helm knowledge is a bit limited at the moment. Would it be okay to open another issue to address the test later? |
eladkal
approved these changes
Apr 28, 2025
Member
Author
|
Thanks for the review! |
jroachgolf84
pushed a commit
to jroachgolf84/airflow
that referenced
this pull request
Apr 30, 2025
guan404ming
changed the title
pod-launcher-rolebinding.yamlpod-launcher-rolebinding.yaml
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Why
The Airflow Helm chart currently uses the
breakfunction inchart/templates/rbac/pod-launcher-rolebinding.yamlwhich lead to error sincebreakis not definedHow
The PR replaces the
breakfunction usage with alternative control flow mechanisms inpod-launcher-rolebinding.yaml^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.