Skip to content

Cleanup type ignores in mysql provider where possible #53288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 6 commits into from
Jul 13, 2025
Merged

Cleanup type ignores in mysql provider where possible #53288

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b02817
Cleanup type ignores in mysql provider where possible
jscheffl Jul 12, 2025
ac630ea
Revert two type ignore cleanups as long as imports with task sdk inco…
jscheffl Jul 13, 2025
5d74deb
Fix typing error and handling of undefined unicode
jscheffl Jul 13, 2025
ffe3c01
Uuups
jscheffl Jul 13, 2025
d000f66
Fix typing errors next round
jscheffl Jul 13, 2025
cf72696
Fix typing errors next round, v2
jscheffl Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions providers/mysql/src/airflow/providers/mysql/hooks/mysql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@
logger = logging.getLogger(__name__)

if TYPE_CHECKING:
from airflow.models import Connection
from airflow.providers.mysql.version_compat import AIRFLOW_V_3_0_PLUS

if AIRFLOW_V_3_0_PLUS:
from airflow.sdk import Connection
else:
from airflow.models.connection import Connection # type: ignore[assignment]

try:
from mysql.connector.abstracts import MySQLConnectionAbstract
Expand Down Expand Up @@ -130,7 +135,7 @@ def _get_conn_config_mysql_client(self, conn: Connection) -> dict:

if conn.extra_dejson.get("charset", False):
conn_config["charset"] = conn.extra_dejson["charset"]
if conn_config["charset"].lower() in ("utf8", "utf-8"):
if str(conn_config.get("charset", "undef")).lower() in ("utf8", "utf-8"):
conn_config["use_unicode"] = True
if conn.extra_dejson.get("cursor", False):
try:
Expand Down Expand Up @@ -220,7 +225,7 @@ def get_conn(self) -> MySQLConnectionTypes:
"installed in case you see compilation error during installation."
)

conn_config = self._get_conn_config_mysql_client(conn) # type: ignore[arg-type]
conn_config = self._get_conn_config_mysql_client(conn)
return MySQLdb.connect(**conn_config)

if client_name == "mysql-connector-python":
Expand All @@ -233,7 +238,7 @@ def get_conn(self) -> MySQLConnectionTypes:
"'mysql-connector-python'. Warning! It might cause dependency conflicts."
)

conn_config = self._get_conn_config_mysql_connector_python(conn) # type: ignore[arg-type]
conn_config = self._get_conn_config_mysql_connector_python(conn)
return mysql.connector.connect(**conn_config)

raise ValueError("Unknown MySQL client name provided!")
Expand All @@ -253,7 +258,7 @@ def bulk_load(self, table: str, tmp_file: str) -> None:
(tmp_file,),
)
conn.commit()
conn.close() # type: ignore[misc]
conn.close()

def bulk_dump(self, table: str, tmp_file: str) -> None:
"""Dump a database table into a tab-delimited file."""
Expand All @@ -270,7 +275,7 @@ def bulk_dump(self, table: str, tmp_file: str) -> None:
(tmp_file,),
)
conn.commit()
conn.close() # type: ignore[misc]
conn.close()

@staticmethod
def _serialize_cell(cell: object, conn: Connection | None = None) -> Any:
Expand Down Expand Up @@ -337,7 +342,7 @@ def bulk_load_custom(

cursor.close()
conn.commit()
conn.close() # type: ignore[misc]
conn.close()

def get_openlineage_database_info(self, connection):
"""Return MySQL specific information for OpenLineage."""
Expand Down