Cleanup type ignores in mysql provider where possible

[jscheffl]

Relates to #53241

[gopidesupavan]

some failures :)

[jscheffl]

some failures :)

@gopidesupavan Here I am a bit unclear. Mypy tells me the type ignores are not needed but if I remove them I get a clash on the other check because of inconsistency between imports from task-sdk vs. airflow-core. Unsure how to fix it... we need compatability but signatures seem to be inconsistent. WDYT?
Argument 1 to "_get_conn_config_mysql_client" of "MySqlHook" has incompatible type "airflow.sdk.definitions.connection.Connection"; expected "airflow.models.connection.Connection" [arg-type]

[gopidesupavan]

some failures :)

@gopidesupavan Here I am a bit unclear. Mypy tells me the type ignores are not needed but if I remove them I get a clash on the other check because of inconsistency between imports from task-sdk vs. airflow-core. Unsure how to fix it... we need compatability but signatures seem to be inconsistent. WDYT? Argument 1 to "_get_conn_config_mysql_client" of "MySqlHook" has incompatible type "airflow.sdk.definitions.connection.Connection"; expected "airflow.models.connection.Connection" [arg-type]

    try:
        from airflow.sdk import Connection
    except ImportError:
        from airflow.models.connection import Connection  # type: ignore[assignment]

I think that should work? under TYPE_CHECKING block

[gopidesupavan]

mypy throwing error in my local here https://github.com/apache/airflow/pull/53288/files#diff-45f9fbfe948e542f1e9ab370ca2c197d2878f76bfc868b015c74665f10fcbef6R133, might cause this buggy if we get some none field. would you like to update part of this PR? or i am happy to push new pr to fix :)

providers/mysql/src/airflow/providers/mysql/hooks/mysql.py:136: error: Item
"None" of "str | Any | None" has no attribute "lower"  [union-attr]
                if conn_config["charset"].lower() in ("utf8", "utf-8"):

[jscheffl]

some failures :)

@gopidesupavan Here I am a bit unclear. Mypy tells me the type ignores are not needed but if I remove them I get a clash on the other check because of inconsistency between imports from task-sdk vs. airflow-core. Unsure how to fix it... we need compatability but signatures seem to be inconsistent. WDYT? Argument 1 to "_get_conn_config_mysql_client" of "MySqlHook" has incompatible type "airflow.sdk.definitions.connection.Connection"; expected "airflow.models.connection.Connection" [arg-type]

    try:
        from airflow.sdk import Connection
    except ImportError:
        from airflow.models.connection import Connection  # type: ignore[assignment]

I think that should work? under TYPE_CHECKING block

Okay, attempted it with a proper version compat, hope this will make it green

[jscheffl]

mypy throwing error in my local here https://github.com/apache/airflow/pull/53288/files#diff-45f9fbfe948e542f1e9ab370ca2c197d2878f76bfc868b015c74665f10fcbef6R133, might cause this buggy if we get some none field. would you like to update part of this PR? or i am happy to push new pr to fix :)

providers/mysql/src/airflow/providers/mysql/hooks/mysql.py:136: error: Item
"None" of "str | Any | None" has no attribute "lower"  [union-attr]
                if conn_config["charset"].lower() in ("utf8", "utf-8"):

Fixing alongside... thanks for the hint...

[gopidesupavan]

mypy throwing error in my local here https://github.com/apache/airflow/pull/53288/files#diff-45f9fbfe948e542f1e9ab370ca2c197d2878f76bfc868b015c74665f10fcbef6R133, might cause this buggy if we get some none field. would you like to update part of this PR? or i am happy to push new pr to fix :)

providers/mysql/src/airflow/providers/mysql/hooks/mysql.py:136: error: Item
"None" of "str | Any | None" has no attribute "lower"  [union-attr]
                if conn_config["charset"].lower() in ("utf8", "utf-8"):

Fixing alongside... thanks for the hint...

cool thank you ;)