Skip to content

Conversation

@teslakoile
Copy link
Contributor

This PR updates the docstrings for the TextEmbeddingModelGetEmbeddingsOperator and GenerativeModelGenerateContentOperator to reflect the latest terminology for Google's Vertex AI services.

The previous documentation referred to the "Vertex AI PaLM API," which is an outdated term. These changes replace it with more accurate descriptions, clarifying that the operators support the broader set of text and multimodal models available through the Vertex AI Generative Model API.

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 21, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 21, 2025
@potiuk
Copy link
Member

potiuk commented Jun 21, 2025

spelling issues to fix

@teslakoile
Copy link
Contributor Author

The GitHub spell check is flagging “multimodal” as a typo, but it seems like a widely accepted term in modern AI contexts.
Should I update the spelling, or is it better to add it to the dictionary?

@Lee-W
Copy link
Member

Lee-W commented Jun 21, 2025

The GitHub spell check is flagging “multimodal” as a typo, but it seems like a widely accepted term in modern AI contexts. Should I update the spelling, or is it better to add it to the dictionary?

let's add it to the spellcheck dict and see how others think 🙂

@teslakoile teslakoile requested a review from Lee-W June 21, 2025 07:38
@potiuk potiuk merged commit fdd9fc1 into apache:main Jun 21, 2025
71 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 21, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Jun 21, 2025
* docs: update vertex AI generative model documentation

* chore: add multimodal to spelling wordlist

---------

Co-authored-by: tm-kyle-naranjo <kyle.n@thinkingmachin.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants