Skip to content

[v3-0-test] Remove unnecessary logs while retrieving connections / variables (#51786) #51826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 1 commit into from
Jun 30, 2025
Merged

[v3-0-test] Remove unnecessary logs while retrieving connections / variables (#51786) #51826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions task-sdk/src/airflow/sdk/execution_time/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ def _get_connection(conn_id: str) -> Connection:
# enabled only if SecretCache.init() has been called first

# iterate over configured backends if not in cache (or expired)
for secrets_backend in ensure_secrets_backend_loaded():
backends = ensure_secrets_backend_loaded()
for secrets_backend in backends:
try:
conn = secrets_backend.get_connection(conn_id=conn_id)
if conn:
Expand All @@ -137,10 +138,11 @@ def _get_connection(conn_id: str) -> Connection:
type(secrets_backend).__name__,
)

log.debug(
"Connection not found in any of the configured Secrets Backends. Trying to retrieve from API server",
conn_id=conn_id,
)
if backends:
log.debug(
"Connection not found in any of the configured Secrets Backends. Trying to retrieve from API server",
conn_id=conn_id,
)

# TODO: This should probably be moved to a separate module like `airflow.sdk.execution_time.comms`
# or `airflow.sdk.execution_time.connection`
Expand Down Expand Up @@ -172,8 +174,9 @@ def _get_variable(key: str, deserialize_json: bool) -> Any:
from airflow.sdk.execution_time.supervisor import ensure_secrets_backend_loaded

var_val = None
backends = ensure_secrets_backend_loaded()
# iterate over backends if not in cache (or expired)
for secrets_backend in ensure_secrets_backend_loaded():
for secrets_backend in backends:
try:
var_val = secrets_backend.get_variable(key=key) # type: ignore[assignment]
if var_val is not None:
Expand All @@ -190,10 +193,11 @@ def _get_variable(key: str, deserialize_json: bool) -> Any:
type(secrets_backend).__name__,
)

log.debug(
"Variable not found in any of the configured Secrets Backends. Trying to retrieve from API server",
key=key,
)
if backends:
log.debug(
"Variable not found in any of the configured Secrets Backends. Trying to retrieve from API server",
key=key,
)

# TODO: This should probably be moved to a separate module like `airflow.sdk.execution_time.comms`
# or `airflow.sdk.execution_time.variable`
Expand Down