[v3-0-test] feat(task_instances): guard ti update state and set task to fail if exception encountered (#51295) #51470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fail if exception encountered (#51295) * feat(task_instances): guard ti update state and set to fail if exception enounctered * feat(task_instances): catch mysql error and set the task to fail * test: remove unnecessay check * fix(task_instances): handle mysql error * refactor(task-instances): merge mysql logic back to the original private function (cherry picked from commit b5a3b4e) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W
approved these changes
Jun 6, 2025
kaxil
pushed a commit
that referenced
this pull request
Jun 6, 2025
…to fail if exception encountered (#51295) (#51470) * feat(task_instances): guard ti update state and set to fail if exception enounctered * feat(task_instances): catch mysql error and set the task to fail * test: remove unnecessay check * fix(task_instances): handle mysql error * refactor(task-instances): merge mysql logic back to the original private function (cherry picked from commit b5a3b4e) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(task_instances): guard ti update state and set to fail if exception enounctered
feat(task_instances): catch mysql error and set the task to fail
test: remove unnecessay check
fix(task_instances): handle mysql error
refactor(task-instances): merge mysql logic back to the original private function
(cherry picked from commit b5a3b4e)
Co-authored-by: Wei Lee weilee.rx@gmail.com