feat(task_instances): guard ti update state and set task to fail if exception encountered #51295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
changed the title
amoghrajesh
reviewed
Jun 2, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
@Lee-W could you please update the PR description with the intent of why you are making this change?
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
Outdated
Show resolved
Hide resolved
Member
Author
it should be a draft one. basically what we discussed this afternoon except for changing task runner is not correct. will update the descipriont after late dinner |
Lee-W
force-pushed
the
guard-ti-update-state
branch
from
8762ed8 to
e724fd4
Compare
Member
Author
|
It would be nice if we could get this one and #50654 reviewed. IMO, the other one is more urgent and important |
Lee-W
changed the title
Lee-W
changed the title
Lee-W
force-pushed
the
guard-ti-update-state
branch
2 times, most recently
from
0f08675 to
022fd63
Compare
uranusjr
reviewed
Jun 3, 2025
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
Outdated
Show resolved
Hide resolved
uranusjr
reviewed
Jun 3, 2025
uranusjr
reviewed
Jun 3, 2025
airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_instances.py
Outdated
Show resolved
Hide resolved
uranusjr
approved these changes
Jun 3, 2025
Member
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
I think this makes sense. A couple of non-blocking comments.
Lee-W
force-pushed
the
guard-ti-update-state
branch
from
d534d82 to
3a34038
Compare
Member
|
Looks like the test failure is relevant. |
Member
Author
Yes, I'm now working on it. Basically, we'll need to remove the future rescheulde from data |
Member
Author
|
just rebuild the query to avoid mysql failure |
vatsrahul1001
approved these changes
Jun 3, 2025
uranusjr
reviewed
Jun 3, 2025
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
Outdated
Show resolved
Hide resolved
amoghrajesh
reviewed
Jun 3, 2025
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
Outdated
Show resolved
Hide resolved
Lee-W
force-pushed
the
guard-ti-update-state
branch
from
0a28e64 to
ac7ffcd
Compare
Member
Author
|
As it has been approved and we're about to start work on releasing 3.0.2, I will merge this one once the CI pass again |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
…to fail if exception encountered (#51295) * feat(task_instances): guard ti update state and set to fail if exception enounctered * feat(task_instances): catch mysql error and set the task to fail * test: remove unnecessay check * fix(task_instances): handle mysql error * refactor(task-instances): merge mysql logic back to the original private function (cherry picked from commit b5a3b4e) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Backport successfully created: v3-0-test
|
kaxil
pushed a commit
that referenced
this pull request
Jun 6, 2025
…to fail if exception encountered (#51295) (#51470) * feat(task_instances): guard ti update state and set to fail if exception enounctered * feat(task_instances): catch mysql error and set the task to fail * test: remove unnecessay check * fix(task_instances): handle mysql error * refactor(task-instances): merge mysql logic back to the original private function (cherry picked from commit b5a3b4e) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
kaxil
pushed a commit
that referenced
this pull request
Jun 6, 2025
…to fail if exception encountered (#51295) (#51470) * feat(task_instances): guard ti update state and set to fail if exception enounctered * feat(task_instances): catch mysql error and set the task to fail * test: remove unnecessay check * fix(task_instances): handle mysql error * refactor(task-instances): merge mysql logic back to the original private function (cherry picked from commit b5a3b4e) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…xception encountered (apache#51295) * feat(task_instances): guard ti update state and set to fail if exception enounctered * feat(task_instances): catch mysql error and set the task to fail * test: remove unnecessay check * fix(task_instances): handle mysql error * refactor(task-instances): merge mysql logic back to the original private function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
closes: #50654
If an unexpected error occurs during task update, the API endpoint crashes with an unhandled exception, and the task state remains, causing the task to hang.
What
Set the task to fail if such case happens
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.