Skip to content

ECS Executor run tasks in bridge network mode #50713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 1 commit into from
May 20, 2025
Merged

ECS Executor run tasks in bridge network mode #50713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions providers/amazon/src/airflow/providers/amazon/aws/executors/ecs/ecs_executor_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,10 @@ def build_task_kwargs() -> dict:
# The executor will overwrite the 'command' property during execution. Must always be the first container!
task_kwargs["overrides"]["containerOverrides"][0]["command"] = [] # type: ignore

if any(
[
subnets := task_kwargs.pop(AllEcsConfigKeys.SUBNETS, None),
security_groups := task_kwargs.pop(AllEcsConfigKeys.SECURITY_GROUPS, None),
# Surrounding parens are for the walrus operator to function correctly along with the None check
(assign_public_ip := task_kwargs.pop(AllEcsConfigKeys.ASSIGN_PUBLIC_IP, None)) is not None,
]
):
subnets = task_kwargs.pop(AllEcsConfigKeys.SUBNETS, None)
security_groups = task_kwargs.pop(AllEcsConfigKeys.SECURITY_GROUPS, None)
assign_public_ip = task_kwargs.pop(AllEcsConfigKeys.ASSIGN_PUBLIC_IP, None)
if subnets or security_groups or assign_public_ip != "False":
network_config = prune_dict(
{
"awsvpcConfiguration": {
Expand Down