Skip to content

Conversation

@bmyers-ozette
Copy link
Contributor

This is a small bugfix to allow running ECS tasks in bridge or host network mode when using the ECS Executor. Bridge and host network mode are incompatible with submitting the networkConfiguration key with the run task api. Since ASSIGN_PUBLIC_IP defaults to false, the if statement always evaluates and includes the network configuration.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels May 16, 2025
@bmyers-ozette bmyers-ozette changed the title assign public ip defaults false ECS Executor run tasks in bridge network mode May 16, 2025
@vincbeck vincbeck merged commit dfec1a7 into apache:main May 20, 2025
70 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented May 20, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants