nit: Switch to using json instead of str when casting collections in OpenLineage #50399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacpermuda
force-pushed
the
ol-collections-json
branch
from
d7d93df to
156fc43
Compare
mobuchowski
reviewed
May 12, 2025
Contributor
mobuchowski
left a comment
mobuchowski
left a comment
There was a problem hiding this comment.
We've done similar thing and reverted it: #41786
If you need the tags in a different format, IMO the right solution would be to add them to a separate field and deprecate (but not remove) the current one.
Contributor
Author
|
I'll add TagJobFacet instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using json when casting collections to string in OL can be helpful for consumers, especially for things like DAG tags that are now casted with
str()which can sometimes be hard to reverse. This is still compliant with the spec, we keep it as string, only changing the quotes for consistent ones really.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.