fix: revert behavior of flattening lists in OpenLineage's InfoJsonEncodable #41786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobuchowski
changed the title
mobuchowski
force-pushed
the
fix-revert-cast-removal
branch
from
4dd2570 to
ae28e3f
Compare
melugoyal
approved these changes
Aug 27, 2024
mobuchowski
force-pushed
the
fix-revert-cast-removal
branch
from
ae28e3f to
f631ee6
Compare
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
mobuchowski
force-pushed
the
fix-revert-cast-removal
branch
from
f631ee6 to
98aa505
Compare
Member
|
Any more context here? Why that was a mistake? |
Contributor
Author
|
@potiuk updated the description |
potiuk
approved these changes
Sep 2, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts back to the behavior that was mistakenly changed in https://github.com/apache/airflow/pull/40371/files#diff-81a199a7e08fbc41cf7960d2725937b3dcfa2694368196681dfe82e3677fed0eL153
This did not match the jsonschema spec of the facet: https://github.com/apache/airflow/blob/9674af5f88929f5057158241330f4ef4fd08beb2/airflow/providers/openlineage/facets/AirflowDagRunFacet.json.
In the near future, we'd like to autogenerate those facets directly from spec as we're already using in
openlineage-python. However, in the meantime, let's manually fix the error.