Skip to content

Conversation

@peter-cheon
Copy link

Although the Helm chart's values.yaml allows configuration for webserverConfig,
there is no corresponding section in the api-server-deployment to apply this configuration.

As a result, even if webserverConfig is added—for example, for LDAP or other authentication settings—it is not properly applied.
To address this, we have added a manifest that includes the necessary configuration.

This update introduces conditional mounting of webserver configuration to the API server deployment. It ensures compatibility when `webserverConfig` or `webserverConfigConfigMapName` is specified. Additional logic for handling related volumes and volume mounts is included.
Corrected the indentation of the podAntiAffinity block in the api-server deployment YAML. This ensures proper configuration parsing and alignment with Kubernetes manifests formatting standards.
@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label May 7, 2025
@boring-cyborg
Copy link

boring-cyborg bot commented May 7, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@peter-cheon
Copy link
Author

@jedcunningham @hussein-awala @dstandish

Hello,
I know you have a busy schedule, but I would greatly appreciate it if you could take a moment to review the code above.

Thank you.

@eladkal eladkal requested a review from romsharon98 June 16, 2025 16:59
@romsharon98
Copy link
Contributor

This does solve the problem, but it's less robust than this solution.
It couples the API server with the webserver configuration, whereas the other PR introduces a new, dedicated configuration option that allows customizing the API server config route independently.

Therefore I am closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants