Skip to content

Adding comprehensive test coverage for get_most_impactful_change #50225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 1 commit into from
May 6, 2025
Merged

Adding comprehensive test coverage for get_most_impactful_change #50225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions dev/breeze/tests/test_provider_documentation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
_get_change_from_line,
_get_changes_classified,
_get_git_log_command,
get_most_impactful_change,
get_version_tag,
)

Expand Down Expand Up @@ -317,3 +318,76 @@ def test_version_bump_for_provider_documentation(initial_version, bump_index, ex

result = bump_version(Version(initial_version), bump_index)
assert str(result) == expected_version


@pytest.mark.parametrize(
"changes, expected",
[
pytest.param([TypeOfChange.SKIP], TypeOfChange.SKIP, id="only-skip"),
pytest.param([TypeOfChange.DOCUMENTATION], TypeOfChange.DOCUMENTATION, id="only-doc"),
pytest.param([TypeOfChange.MISC], TypeOfChange.MISC, id="only-misc"),
pytest.param([TypeOfChange.BUGFIX], TypeOfChange.BUGFIX, id="only-bugfix"),
pytest.param(
[TypeOfChange.MIN_AIRFLOW_VERSION_BUMP],
TypeOfChange.MIN_AIRFLOW_VERSION_BUMP,
id="only-min-airflow-bump",
),
pytest.param([TypeOfChange.FEATURE], TypeOfChange.FEATURE, id="only-feature"),
pytest.param([TypeOfChange.BREAKING_CHANGE], TypeOfChange.BREAKING_CHANGE, id="only-breaking"),
pytest.param(
[TypeOfChange.SKIP, TypeOfChange.DOCUMENTATION], TypeOfChange.DOCUMENTATION, id="doc-vs-skip"
),
pytest.param([TypeOfChange.SKIP, TypeOfChange.MISC], TypeOfChange.MISC, id="misc-vs-skip"),
pytest.param([TypeOfChange.DOCUMENTATION, TypeOfChange.MISC], TypeOfChange.MISC, id="misc-vs-doc"),
pytest.param([TypeOfChange.MISC, TypeOfChange.BUGFIX], TypeOfChange.BUGFIX, id="bugfix-vs-misc"),
pytest.param(
[TypeOfChange.BUGFIX, TypeOfChange.MIN_AIRFLOW_VERSION_BUMP],
TypeOfChange.MIN_AIRFLOW_VERSION_BUMP,
id="bump-vs-bugfix",
),
pytest.param(
[TypeOfChange.MIN_AIRFLOW_VERSION_BUMP, TypeOfChange.FEATURE],
TypeOfChange.FEATURE,
id="feature-vs-bump",
),
pytest.param(
[TypeOfChange.FEATURE, TypeOfChange.BREAKING_CHANGE],
TypeOfChange.BREAKING_CHANGE,
id="breaking-vs-feature",
),
# Bigger combos
pytest.param(
[
TypeOfChange.SKIP,
TypeOfChange.DOCUMENTATION,
TypeOfChange.MISC,
TypeOfChange.BUGFIX,
TypeOfChange.MIN_AIRFLOW_VERSION_BUMP,
TypeOfChange.FEATURE,
TypeOfChange.BREAKING_CHANGE,
],
TypeOfChange.BREAKING_CHANGE,
id="full-spectrum",
),
pytest.param(
[
TypeOfChange.DOCUMENTATION,
TypeOfChange.BUGFIX,
TypeOfChange.MIN_AIRFLOW_VERSION_BUMP,
],
TypeOfChange.MIN_AIRFLOW_VERSION_BUMP,
id="version-bump-over-bugfix-doc",
),
pytest.param(
[
TypeOfChange.DOCUMENTATION,
TypeOfChange.MISC,
TypeOfChange.SKIP,
],
TypeOfChange.MISC,
id="misc-over-doc-skip",
),
],
)
def test_get_most_impactful_change(changes, expected):
assert get_most_impactful_change(changes) == expected
Loading