Skip to content

Skip provider tests when tests are skipped in general #49968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Apr 29, 2025
Merged

Skip provider tests when tests are skipped in general #49968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,8 @@ jobs:
packages: read
if: >
needs.build-info.outputs.skip-providers-tests != 'true' &&
needs.build-info.outputs.latest-versions-only != 'true'
needs.build-info.outputs.latest-versions-only != 'true' &&
needs.build-info.outputs.run-tests == 'true'
with:
runs-on-as-json-default: ${{ needs.build-info.outputs.runs-on-as-json-default }}
canary-run: ${{ needs.build-info.outputs.canary-run }}
Expand Down
4 changes: 4 additions & 0 deletions dev/breeze/src/airflow_breeze/utils/selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,6 +777,8 @@ def needs_helm_tests(self) -> bool:

@cached_property
def run_tests(self) -> bool:
if self.full_tests_needed:
return True
if self._is_canary_run():
return True
if self.only_new_ui_files:
Expand Down Expand Up @@ -1223,6 +1225,8 @@ def skip_providers_tests(self) -> bool:
return False
if self._get_providers_test_types_to_run():
return False
if not self.run_tests:
return True
return True

@cached_property
Expand Down