Skip provider tests when tests are skipped in general #49968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tests are skipped in general, provider tests should also be skipped. There was a case where tests were skipped because the change was "ui-only" - in this case "run-tests" was set to false but the "skip-provider-tests" was set to false.
potiuk
requested review from
amoghrajesh,
ashb,
gopidesupavan and
jedcunningham
as code owners
gopidesupavan
approved these changes
Apr 29, 2025
vincbeck
approved these changes
Apr 29, 2025
mvfc
pushed a commit
to mvfc/airflow
that referenced
this pull request
Apr 29, 2025
When tests are skipped in general, provider tests should also be skipped. There was a case where tests were skipped because the change was "ui-only" - in this case "run-tests" was set to false but the "skip-provider-tests" was set to false.
jroachgolf84
pushed a commit
to jroachgolf84/airflow
that referenced
this pull request
Apr 30, 2025
When tests are skipped in general, provider tests should also be skipped. There was a case where tests were skipped because the change was "ui-only" - in this case "run-tests" was set to false but the "skip-provider-tests" was set to false.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 14, 2025
…ache#49968) When tests are skipped in general, provider tests should also be skipped. There was a case where tests were skipped because the change was "ui-only" - in this case "run-tests" was set to false but the "skip-provider-tests" was set to false. (cherry picked from commit dab52dd) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tests are skipped in general, provider tests should also be skipped. There was a case where tests were skipped because the change was "ui-only" - in this case "run-tests" was set to false but the "skip-provider-tests" was set to false.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.