Skip to content

Conversation

@GrumpyCat51
Copy link
Contributor

The helm chart still references the hybrid operators as valid options. As I didn't really notice this change when going through the release notes, this hopefully helps other people from trying to select the CeleryKubernetesOperator and debug the resulting errors.

closes: #49897
related: #47322


Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 28, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@GrumpyCat51
Copy link
Contributor Author

@kaxil with #49897 (comment) in mind, are the two suggestions above still valid?

@kaxil
Copy link
Member

kaxil commented Apr 29, 2025

@kaxil with #49897 (comment) in mind, are the two suggestions above still valid?

Yup, I meant No, I had resolved those comments :) Sry for the confusion

@kaxil kaxil enabled auto-merge (squash) April 29, 2025 09:34
auto-merge was automatically disabled April 30, 2025 07:07

Head branch was pushed to by a user without write access

Co-authored-by: Niko Oliveira <onikolas@amazon.com>
@GrumpyCat51
Copy link
Contributor Author

@kaxil this should be ready to be merged

@eladkal
Copy link
Contributor

eladkal commented May 5, 2025

I don't think we can/should.
The chart supports Airflow 1.10+ this executor is valid option for older Airflow versions.

@o-nikolas
Copy link
Contributor

I don't think we can/should.
The chart supports Airflow 1.10+ this executor is valid option for older Airflow versions.

See the code changes themselves, those executors are still mentioned for the <3.0 case

@eladkal
Copy link
Contributor

eladkal commented May 5, 2025

I don't think we can/should.
The chart supports Airflow 1.10+ this executor is valid option for older Airflow versions.

See the code changes themselves, those executors are still mentioned for the <3.0 case

Ah hard to review from mobile.

Then commit message needs to be amended to reflect the actual change

@o-nikolas o-nikolas changed the title remove celerykubernetesexecutor from docs Add 3.X/2.X clarification for celerykubernetesexecutor in Helm Chart docs May 5, 2025
@o-nikolas
Copy link
Contributor

I don't think we can/should.
The chart supports Airflow 1.10+ this executor is valid option for older Airflow versions.

See the code changes themselves, those executors are still mentioned for the <3.0 case

Ah hard to review from mobile.

Then commit message needs to be ammended to reflect the actual change

Sure, I updated it for @GrumpyCat51

@o-nikolas o-nikolas merged commit 3e1ab48 into apache:main May 5, 2025
65 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented May 5, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@eladkal eladkal added this to the Airflow Helm Chart 1.17.0 milestone May 5, 2025
mvfc pushed a commit to mvfc/airflow that referenced this pull request May 6, 2025
…docs (apache#49916)

Co-authored-by: Yannick Suter <yannick.suter@reprisk.com>
Co-authored-by: Niko Oliveira <onikolas@amazon.com>
@GrumpyCat51 GrumpyCat51 deleted the remove-celerykubernetesoperator-from-helm-chart-docs branch May 6, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing CeleryKubernetesExecutor

6 participants