-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add 3.X/2.X clarification for celerykubernetesexecutor in Helm Chart docs #49916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3.X/2.X clarification for celerykubernetesexecutor in Helm Chart docs #49916
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
@kaxil with #49897 (comment) in mind, are the two suggestions above still valid? |
|
Head branch was pushed to by a user without write access
Co-authored-by: Niko Oliveira <onikolas@amazon.com>
|
@kaxil this should be ready to be merged |
|
I don't think we can/should. |
See the code changes themselves, those executors are still mentioned for the <3.0 case |
Ah hard to review from mobile. Then commit message needs to be amended to reflect the actual change |
Sure, I updated it for @GrumpyCat51 |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…docs (apache#49916) Co-authored-by: Yannick Suter <yannick.suter@reprisk.com> Co-authored-by: Niko Oliveira <onikolas@amazon.com>
The helm chart still references the hybrid operators as valid options. As I didn't really notice this change when going through the release notes, this hopefully helps other people from trying to select the
CeleryKubernetesOperatorand debug the resulting errors.closes: #49897
related: #47322
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.