Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Apr 25, 2025


^ Add meaningful description above

Here is the implementation for the reported bug closes: #49731

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 25, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal changed the title change hook in generic_transfer.py fix: wrong hook on SQL operator GenericTransfer Apr 25, 2025
@dabla
Copy link
Contributor

dabla commented Apr 25, 2025

@Baptistouille Thx for the fix, but I think it's best we add an assertion on the invoked hooks (e.g. source/destination) as well to avoid mistakes in the future as well. You can add the assertion of the test_paginated_read method in test_generic_transfer.

@ghost
Copy link
Author

ghost commented Apr 28, 2025

@dabla Thanks for pointing out tests.
I made a proposal to cover not paginated case that wasn't. And updated yours to check that the right hooks' methods has been called in case of paginated execution.

@eladkal
Copy link
Contributor

eladkal commented May 22, 2025

Fixed in #50598

@eladkal eladkal closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrong hook on SQL operator GenericTransfert

3 participants