Elasticsearch : Ignore cursor specific parameters when instantiating the connection #48865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…csearch connection
jason810496
approved these changes
Apr 7, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Nice catch! Looks good to me.
Lee-W
reviewed
Apr 14, 2025
providers/elasticsearch/tests/unit/elasticsearch/hooks/test_elasticsearch.py
Show resolved
Hide resolved
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the implementation of this PR, we discovered that when passing cursor specific parameters through the extra parameters of the Elasticsearch connection, the instantiation of the ESConnection failed due to the fact the same arguments where also passed there but aren't recognized. So this PR fixes that issue.
The cursor specific parameters are fetch_size and field_multi_value_leniency, which aren't allowed parameters for the Elasticsearch client.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.