Implemented cursor for ElasticsearchSQLHook so it can be used through SQLExecuteQueryOperator #46439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
… in ElasticsearchSQLCursor
insomnes
pushed a commit
to insomnes/airflow
that referenced
this pull request
Feb 6, 2025
… SQLExecuteQueryOperator (apache#46439) --------- Co-authored-by: David Blain <david.blain@infrabel.be>
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
… SQLExecuteQueryOperator (apache#46439) --------- Co-authored-by: David Blain <david.blain@infrabel.be>
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
… SQLExecuteQueryOperator (apache#46439) --------- Co-authored-by: David Blain <david.blain@infrabel.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a PEP 249-like cursor (e.g. ElasticsearchSQLCursor) so the ElasticsearchSQLHook (which is a specialization of the DbApiHook) can be used through the SQLExecuteQueryOperator.
The issue is that the TestElasticsearchSQLHook mocks the cursor and thus gives the impression the ESConnection has a cursor available which is internally used by the run method of the DbApiHook but in reality doesn't exist, this means at runtime the SQLExecuteQueryOperator will fail.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.