Skip to content

Conversation

@james5418
Copy link
Contributor

@james5418 james5418 commented Apr 4, 2025

Closes: #48685

Also, unit tests for hdfs logging (HdfsTaskHandler) were added.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 4, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal requested a review from ashb April 4, 2025 08:41
@eladkal
Copy link
Contributor

eladkal commented Apr 4, 2025

There are mypy failures

@eladkal
Copy link
Contributor

eladkal commented Apr 4, 2025

Needs also to apply patch for ti read similar to #48804

@ashb
Copy link
Member

ashb commented Apr 4, 2025

Needs also to apply patch for ti read similar to #48804

And now upload.

@james5418 james5418 force-pushed the hdfstaskhandler-structlog-rework branch from dd319b4 to 0a25407 Compare April 5, 2025 06:33
@james5418
Copy link
Contributor Author

There are mypy failures

I just added # type: ignore on this line to bypass the mypy type-checking error.

@eladkal eladkal requested a review from ashb April 7, 2025 08:50
@james5418 james5418 force-pushed the hdfstaskhandler-structlog-rework branch from 7e0abfc to 7983867 Compare April 8, 2025 00:13
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
cc @ashb

@ashb ashb merged commit b8b2160 into apache:main Apr 10, 2025
62 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 10, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HdfsTaskHandler - Rework remote task log handling for the structlog era

3 participants