-
Notifications
You must be signed in to change notification settings - Fork 16.4k
HdfsTaskHandler structlog rework #48788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
airflow-core/src/airflow/config_templates/airflow_local_settings.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/config_templates/airflow_local_settings.py
Outdated
Show resolved
Hide resolved
|
There are mypy failures |
|
Needs also to apply patch for ti read similar to #48804 |
And now upload. |
dd319b4 to
0a25407
Compare
I just added |
7e0abfc to
7983867
Compare
eladkal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @ashb
airflow-core/src/airflow/config_templates/airflow_local_settings.py
Outdated
Show resolved
Hide resolved
providers/apache/hdfs/src/airflow/providers/apache/hdfs/log/hdfs_task_handler.py
Show resolved
Hide resolved
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Closes: #48685
Also, unit tests for hdfs logging (
HdfsTaskHandler) were added.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.