Skip to content

Conversation

@danielcarletti
Copy link
Contributor

Bump Helm Version Requirement to 3.10+

Description

This PR updates the required Helm version for deploying Apache Airflow from 3.0+ to 3.10+. The change aligns with the minimum version needed for compatibility with newer Helm features used in the Helm chart, particularly the break statement introduced in 972714e (in airflow/templates/rbac/pod-launcher-rolebinding.yaml:66)

Related Issues

N/A

Changes Made

  • Updated Helm version requirement in relevant documentation and configurations.

Testing

  • No functional changes were introduced.
  • Verified that Helm 3.10+ works as expected with the deployment.

Checklist

  • My PR includes unit tests / doc updates if applicable.
  • My PR follows the project's coding style and best practices.
  • I have run pre-commit locally to validate formatting and linting.
  • My PR is focused on a single change and does not introduce unrelated modifications.
  • I have rebased my branch onto the latest main.
  • All CI checks have passed.

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 2, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk merged commit 902e68e into apache:main Apr 7, 2025
60 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 7, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@eladkal eladkal added this to the Airflow Helm Chart 1.17.0 milestone Apr 7, 2025
@danielcarletti danielcarletti deleted the danielcarletti-fix-helm-version-doc branch April 7, 2025 12:14
simonprydden pushed a commit to simonprydden/airflow that referenced this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants