Skip to content

Conversation

@Crowiant
Copy link
Contributor

Update of API version to support v19 of Google ADS


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Mar 14, 2025
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 14, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are changes in docs required for this?

@Crowiant
Copy link
Contributor Author

I checked the same PR regarding the upgrade from v17 to v18 (#40158) and didn´t see any changes related to the documentation. So, I guess not.

@eladkal
Copy link
Contributor

eladkal commented Mar 14, 2025

I checked the same PR regarding the upgrade from v17 to v18 (#40158) and didn´t see any changes related to the documentation. So, I guess not.

It's not the same is it?
v18 is not even deprecated. According to https://developers.google.com/google-ads/api/docs/sunset-dates it will be deprecated in June 2025.
We need Google team to agree accepting it. cc @VladaZakharova

@VladaZakharova
Copy link
Contributor

I checked the same PR regarding the upgrade from v17 to v18 (#40158) and didn´t see any changes related to the documentation. So, I guess not.

It's not the same is it? v18 is not even deprecated. According to https://developers.google.com/google-ads/api/docs/sunset-dates it will be deprecated in June 2025. We need Google team to agree accepting it. cc @VladaZakharova

Hi there :)
Yes, this is a valid change, so approved 👍

@eladkal
Copy link
Contributor

eladkal commented Mar 14, 2025

Hi there :) Yes, this is a valid change, so approved 👍

Great

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge when CI pass

@VladaZakharova
Copy link
Contributor

I'll merge when CI pass

Thank you so much :)

@eladkal eladkal merged commit 8d0203b into apache:main Mar 14, 2025
62 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 14, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

agupta01 pushed a commit to agupta01/airflow that referenced this pull request Mar 21, 2025
Co-authored-by: Anton Nitochkin <nitochkin@google.com>
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants