-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Alternative method to mark source roots in PyCharm/IntelliJ IDEA #47184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
To save few clicks from manually select each directory 😄 We can update this file as we restructure so that it will be easy to fixup all in one go |
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for adding!
contributing-docs/quick-start-ide/contributors_quick_start_pycharm.rst
Outdated
Show resolved
Hide resolved
|
Hmm. I thought about it, but there are two things:
They seem to be portable, with relative references - IntelliJ ultimate and Pycharm seem to have the same format and work similarly, I can't see why we should not be able remove those files from .gitignore and commit them. |
|
We could also commit equivalent configuration from vscode if it is portable and separate from all other vscode configuration. |
|
The only problem I see that in breeze we might want to have another venv: (BTW. It's funny how you can see that IntelliJ is just twisted java environment... jdkName= "Python 3.12 (breeze)" 🤣 |
|
BTW. I am not super strong on the committing, copying the files will mostly work as well, and that "jdk" is potentially blocking, but might be worth seeing if that will work :). It woudl be awesome if contributor just opens the |
For JdkName it actually auto populated when i created virtual environment, so when we change interpreter paths in Pycharm settings then that will update the airflow.iml file. i have tested changing multiple paths in pycharm interpreter its updating the airflow.impl file ah not sure how to setup when airflow folder opens :) |
|
I have another idea, can add python script, it generates airflow.iml, module.xml files and updates automatically something like this cli. python setup_ide.py --venv_name {} We can update this script whenever changes happens :) ? So users has to run first time and when any new changes happens. |
That seems like a nice middle ground |
…harm.rst Co-authored-by: Kalyan R <kalyan.ben10@live.com>
ed37d9b to
ee679cc
Compare
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
|
Constraint/static check failure is setuptools mayhem - being fixed in #48210 |
…che#47184) * add pycharm idea airflow impl file to mark source root and tests * add pycharm idea airflow impl file to mark source root and tests * Update contributing-docs/quick-start-ide/contributors_quick_start_pycharm.rst Co-authored-by: Kalyan R <kalyan.ben10@live.com> * Update setup_idea script to create source roots in PyCharm and IntelliJ --------- Co-authored-by: Kalyan R <kalyan.ben10@live.com>
…che#47184) * add pycharm idea airflow impl file to mark source root and tests * add pycharm idea airflow impl file to mark source root and tests * Update contributing-docs/quick-start-ide/contributors_quick_start_pycharm.rst Co-authored-by: Kalyan R <kalyan.ben10@live.com> * Update setup_idea script to create source roots in PyCharm and IntelliJ --------- Co-authored-by: Kalyan R <kalyan.ben10@live.com>
…che#47184) * add pycharm idea airflow impl file to mark source root and tests * add pycharm idea airflow impl file to mark source root and tests * Update contributing-docs/quick-start-ide/contributors_quick_start_pycharm.rst Co-authored-by: Kalyan R <kalyan.ben10@live.com> * Update setup_idea script to create source roots in PyCharm and IntelliJ --------- Co-authored-by: Kalyan R <kalyan.ben10@live.com>
…che#47184) * add pycharm idea airflow impl file to mark source root and tests * add pycharm idea airflow impl file to mark source root and tests * Update contributing-docs/quick-start-ide/contributors_quick_start_pycharm.rst Co-authored-by: Kalyan R <kalyan.ben10@live.com> * Update setup_idea script to create source roots in PyCharm and IntelliJ --------- Co-authored-by: Kalyan R <kalyan.ben10@live.com>
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.