Skip to content

Conversation

@oryanperl
Copy link
Contributor

@oryanperl oryanperl commented Feb 26, 2025

Hi!
Adding a support. for passing initialDelaySeconds to airflow startupProbes.
This is a direct continuation of the issue i opened
closes: #47093


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 26, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@oryanperl oryanperl force-pushed the chart-add-initialDelaySeconds-to-startupProbe branch from a9fad4e to 253d488 Compare February 26, 2025 10:49
@eladkal
Copy link
Contributor

eladkal commented Feb 28, 2025

Needs rebase and reaolve conflicts

@oryanperl
Copy link
Contributor Author

Needs rebase and reaolve conflicts

done, thanks

@eladkal eladkal added this to the Airflow Helm Chart 1.16.0 milestone Mar 2, 2025
@eladkal eladkal requested a review from romsharon98 March 2, 2025 12:00
@oryanperl
Copy link
Contributor Author

@eladkal @romsharon98 Hi, tests failed locally so i fixed a small issue with renaming, could you please re-run tests the workflow? it completes successfully locally now

@romsharon98 romsharon98 merged commit 073353b into apache:main Mar 7, 2025
59 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 7, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing initialDelaySeconds configuration of startupProbe

4 participants