Fix lookup_from_deprecated_options in AirflowConfigParser
#47004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunank200
reviewed
Feb 24, 2025
jason810496
force-pushed
the
fix/conf-lookup-from-deprecated-options-with-configuration-description
branch
from
47e71da to
cf88e22
Compare
bugraoz93
reviewed
Feb 24, 2025
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
Looks good in general, thanks!
jason810496
force-pushed
the
fix/conf-lookup-from-deprecated-options-with-configuration-description
branch
2 times, most recently
from
fc74498 to
4b171be
Compare
Lee-W
reviewed
Mar 3, 2025
jason810496
force-pushed
the
fix/conf-lookup-from-deprecated-options-with-configuration-description
branch
from
4b171be to
fcceba8
Compare
Member
Author
|
Thanks @Lee-W for the review. Just resolved and rebased it. |
Lee-W
approved these changes
Mar 5, 2025
shahar1
pushed a commit
to shahar1/airflow
that referenced
this pull request
Mar 5, 2025
…7004) * Fix deprecated_options in AirflowConfigParser * Add test_deprecated_options_with_lookup_from_deprecated, rename as lookup_from_deprecated * fixup! Add docstring for lookup_from_deprecated * Fix fixture params naming
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…7004) * Fix deprecated_options in AirflowConfigParser * Add test_deprecated_options_with_lookup_from_deprecated, rename as lookup_from_deprecated * fixup! Add docstring for lookup_from_deprecated * Fix fixture params naming
Lee-W
pushed a commit
that referenced
this pull request
May 9, 2025
…50353) * Fix Legacy configuration not removed or updated (#46544) * Fix Legacy configuration not removed or updated (cherry picked from commit 9719737) * allow_trigger_in_future config removal (#46667) (cherry picked from commit 65bacad) * Backport airflow config update and airflow config lint changes * Rename pre-2-7 defaults to provider_config_fallback_defaults (#44895) * Rename pre-2-7 defaults to provider_config_fallback_defaults After unsuccessful atempts to remove them, renaming and adding appropriate warning against removing them seems to be a good idea. * Update airflow/config_templates/provider_config_fallback_defaults.cfg Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> (cherry picked from commit 8c013b6) * Fix `lookup_from_deprecated_options` in AirflowConfigParser (#47004) * Fix deprecated_options in AirflowConfigParser * Add test_deprecated_options_with_lookup_from_deprecated, rename as lookup_from_deprecated * fixup! Add docstring for lookup_from_deprecated * Fix fixture params naming (cherry picked from commit 8e3d25f) * Fix the tests --------- Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> Co-authored-by: Phani Kumar <94376113+phanikumv@users.noreply.github.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: https://github.com/apache/airflow/pull/46544/files/b6ac7467b0bfc36831185219112354ea22da29f4#r1966113213
Why
option_descriptionshould beself.configuration_description.get(section, {}).get("options", {}).get(key, {})instead ofself.configuration_description.get(section, {}).get(key, {})and the corresponding test is missing.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.