Fix Legacy configuration not removed or updated #46544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Followup: Should we add a |
Member
sounds like a great idea! |
jason810496
requested review from
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
jason810496
force-pushed
the
fix/legacy-configuration-not-removed-or-updated
branch
from
96b4fd2 to
ed8c6bd
Compare
Lee-W
added
the
full tests needed
jason810496
force-pushed
the
fix/legacy-configuration-not-removed-or-updated
branch
from
ed8c6bd to
8ff3f65
Compare
Lee-W
approved these changes
Feb 10, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
left a few nitpicks. overall looks good
jason810496
force-pushed
the
fix/legacy-configuration-not-removed-or-updated
branch
from
8ff3f65 to
ff092b5
Compare
Member
|
Thanks for addressing this. Will leave this open for 1 or 2 days before merging. |
jason810496
force-pushed
the
fix/legacy-configuration-not-removed-or-updated
branch
from
ff092b5 to
b6ac746
Compare
Member
|
ah... forget to merge it . will do once CI is green again |
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* Fix Legacy configuration not removed or updated * Fix webserver cookie_samesite fallback * Fix nitpicks
ashb
reviewed
Feb 21, 2025
| section = self.inversed_deprecated_sections[section] | ||
| if not self._suppress_future_warnings: | ||
| if lookup_from_deprecated_options: | ||
| option_description = self.configuration_description.get(section, {}).get(key, {}) |
Member
There was a problem hiding this comment.
@Lee-W @jason810496 So it turns out this was inaddequately tested before, and was already not working.
This should be self.configuration_description.get(section, {}).get("options", {}).get(key, {})
@jason810496 Would you mind fixing this and adding tests for it?
Member
Author
There was a problem hiding this comment.
Sure, I will create a PR to fix it I the weekend ( currently out of laptop. If this is very urgent then I might not be able to solve it immediately. )
Member
There was a problem hiding this comment.
Of course, no rush! It's been broken for a some unknown time, you were just the unfortunate soul who touched it last 😁
sunank200
added
the
backport-to-v2-11-test
2 tasks
sunank200
pushed a commit
to astronomer/airflow
that referenced
this pull request
May 8, 2025
* Fix Legacy configuration not removed or updated * Fix webserver cookie_samesite fallback * Fix nitpicks (cherry picked from commit 9719737)
sunank200
pushed a commit
to astronomer/airflow
that referenced
this pull request
May 8, 2025
* Fix Legacy configuration not removed or updated (cherry picked from commit 9719737)
Lee-W
pushed a commit
that referenced
this pull request
May 9, 2025
…50353) * Fix Legacy configuration not removed or updated (#46544) * Fix Legacy configuration not removed or updated (cherry picked from commit 9719737) * allow_trigger_in_future config removal (#46667) (cherry picked from commit 65bacad) * Backport airflow config update and airflow config lint changes * Rename pre-2-7 defaults to provider_config_fallback_defaults (#44895) * Rename pre-2-7 defaults to provider_config_fallback_defaults After unsuccessful atempts to remove them, renaming and adding appropriate warning against removing them seems to be a good idea. * Update airflow/config_templates/provider_config_fallback_defaults.cfg Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> (cherry picked from commit 8c013b6) * Fix `lookup_from_deprecated_options` in AirflowConfigParser (#47004) * Fix deprecated_options in AirflowConfigParser * Add test_deprecated_options_with_lookup_from_deprecated, rename as lookup_from_deprecated * fixup! Add docstring for lookup_from_deprecated * Fix fixture params naming (cherry picked from commit 8e3d25f) * Fix the tests --------- Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> Co-authored-by: Phani Kumar <94376113+phanikumv@users.noreply.github.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #46517
The
inversed_deprecated_optionslogic inconfig_command.pycausesconfig lintto retrieve the new section-option pair from the old section-option pair. Adding thelookup_from_deprecated_optionsargument can resolve the error.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.