Skip to content

Conversation

@wjszlachta-man
Copy link
Contributor

This fixes a bug where task deserialisation fails with TypeError when task execution_timeout is set to None, but core.default-task-execution-timeout is not set to None in airflow.cfg.

In order to reproduce:

  • set core.default-task-execution-timeout in airflow.cfg to any integer value
  • set execution_timeout=None on any operator inside a DAG
  • open DAG in Airflow UI
  • you will see Internal Server Error in the browser, and the following in webserver logs:
...
airflow/serialization/serialized_objects.py:1488: in deserialize_operator
    cls.populate_operator(op, encoded_op)
airflow/serialization/serialized_objects.py:1345: in populate_operator
    v = cls._deserialize_timedelta(v)
airflow/serialization/serialized_objects.py:941: in _deserialize_timedelta
    return datetime.timedelta(seconds=seconds)
E   TypeError: unsupported type for timedelta seconds component: NoneType

If you are running with scheduler.standalone-dag-processor set to True, this is more catastrophic as you will see the same deserialization error in scheduler and you will not be able to schedule any new tasks.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 14, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@wjszlachta-man wjszlachta-man force-pushed the fix-task-execution-timeout-deserialization branch from b4acb05 to ebce426 Compare February 14, 2025 15:48
@potiuk potiuk added this to the Airflow 2.10.6 milestone Feb 15, 2025
@potiuk potiuk merged commit 97d62ee into apache:main Feb 17, 2025
45 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 17, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@github-actions
Copy link

Backport failed to create: v2-10-test. View the failure log Run details

Status Branch Result
v2-10-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 97d62ee v2-10-test

This should apply the commit to the v2-10-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

potiuk pushed a commit to potiuk/airflow that referenced this pull request Feb 17, 2025
…to `None` (apache#46766)

* Fix TypeError when deserializing task with None execution_timeout

* Fix pytest-extraneous-scope-function (PT003)

(cherry picked from commit 97d62ee)
potiuk pushed a commit to potiuk/airflow that referenced this pull request Feb 17, 2025
…to `None` (apache#46766)

* Fix TypeError when deserializing task with None execution_timeout

* Fix pytest-extraneous-scope-function (PT003)

(cherry picked from commit 97d62ee)
dantonbertuol pushed a commit to dantonbertuol/airflow that referenced this pull request Feb 17, 2025
…to `None` (apache#46766)

* Fix TypeError when deserializing task with None execution_timeout

* Fix pytest-extraneous-scope-function (PT003)
potiuk pushed a commit to potiuk/airflow that referenced this pull request Feb 17, 2025
…to `None` (apache#46766)

* Fix TypeError when deserializing task with None execution_timeout

* Fix pytest-extraneous-scope-function (PT003)

(cherry picked from commit 97d62ee)
potiuk added a commit that referenced this pull request Feb 17, 2025
…to `None` (#46766) (#46822)

* Fix TypeError when deserializing task with None execution_timeout

* Fix pytest-extraneous-scope-function (PT003)

(cherry picked from commit 97d62ee)

Co-authored-by: Wojciech Szlachta <wojciech.szlachta@man.com>
@potiuk
Copy link
Member

potiuk commented Feb 17, 2025

backported to v2-10-test

ntr pushed a commit to ntr/airflow that referenced this pull request Feb 20, 2025
…to `None` (apache#46766)

* Fix TypeError when deserializing task with None execution_timeout

* Fix pytest-extraneous-scope-function (PT003)
@kaxil kaxil modified the milestones: Airflow 2.10.6, Airflow 2.11.0 Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants