-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix TypeError when deserializing task with execution_timeout set to None
#46766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TypeError when deserializing task with execution_timeout set to None
#46766
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
b4acb05 to
ebce426
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Backport failed to create: v2-10-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 97d62ee v2-10-testThis should apply the commit to the v2-10-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
…to `None` (apache#46766) * Fix TypeError when deserializing task with None execution_timeout * Fix pytest-extraneous-scope-function (PT003) (cherry picked from commit 97d62ee)
…to `None` (apache#46766) * Fix TypeError when deserializing task with None execution_timeout * Fix pytest-extraneous-scope-function (PT003) (cherry picked from commit 97d62ee)
…to `None` (apache#46766) * Fix TypeError when deserializing task with None execution_timeout * Fix pytest-extraneous-scope-function (PT003)
…to `None` (apache#46766) * Fix TypeError when deserializing task with None execution_timeout * Fix pytest-extraneous-scope-function (PT003) (cherry picked from commit 97d62ee)
|
backported to v2-10-test |
…to `None` (apache#46766) * Fix TypeError when deserializing task with None execution_timeout * Fix pytest-extraneous-scope-function (PT003)
This fixes a bug where task deserialisation fails with
TypeErrorwhen taskexecution_timeoutis set toNone, but core.default-task-execution-timeout is not set toNoneinairflow.cfg.In order to reproduce:
airflow.cfgto any integer valueexecution_timeout=Noneon any operator inside a DAGInternal Server Errorin the browser, and the following inwebserverlogs:If you are running with scheduler.standalone-dag-processor set to
True, this is more catastrophic as you will see the same deserialization error inschedulerand you will not be able to schedule any new tasks.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.