Skip to content

Conversation

@ashb
Copy link
Member

@ashb ashb commented Feb 6, 2025

This is part of the AIP-83 ammendments.

Closes #46521


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@ashb
Copy link
Member Author

ashb commented Feb 6, 2025

This also fixes #46521 in the way going forward. If this doesn't pass tests lets go for that version though, and we'll need something like this once #46512 is merged.

Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks okay. But we will need to complete the change for the default logical date to null when manual trigger from UI.

@ashb ashb force-pushed the aip-83-task-context-dict branch 2 times, most recently from b9668e1 to 7653152 Compare February 6, 2025 14:18
@sunank200 sunank200 added the AIP-83 Remove Execution Date Unique Constraint from DAG Run label Feb 6, 2025
@sunank200 sunank200 requested a review from uranusjr February 6, 2025 14:30
…s defined

This is part of the AIP-83 ammendments.
@ashb ashb force-pushed the aip-83-task-context-dict branch from 7653152 to d6a9140 Compare February 6, 2025 14:57
@ashb ashb requested a review from potiuk as a code owner February 6, 2025 14:57
@ashb ashb merged commit 993a009 into main Feb 6, 2025
63 checks passed
@ashb ashb deleted the aip-83-task-context-dict branch February 6, 2025 16:40
insomnes pushed a commit to insomnes/airflow that referenced this pull request Feb 6, 2025
…s defined (apache#46522)

This is part of the AIP-83 amendments.
insomnes pushed a commit to insomnes/airflow that referenced this pull request Feb 6, 2025
…s defined (apache#46522)

This is part of the AIP-83 amendments.
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
…s defined (apache#46522)

This is part of the AIP-83 amendments.
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
…s defined (apache#46522)

This is part of the AIP-83 amendments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIP-83 Remove Execution Date Unique Constraint from DAG Run area:task-sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants