Change manual run data interval behavior based on logical_date #46512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunank200
requested review from
ashb,
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
sunank200
requested review from
uranusjr
and removed request for
ashb,
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
1 task
sunank200
force-pushed
the
null-logical-date-for-ui-trigger
branch
from
fae6d58 to
b55987e
Compare
Member
|
We should probably not change the old UI anymore (we're very close to removing it), but we should change the New FastAPI routes instead |
vatsrahul1001
approved these changes
Feb 6, 2025
uranusjr
reviewed
Feb 7, 2025
Member
|
By “soon” it’s after 3.0 right? I feel we should still keep the old view work the same as the new to not confuse users too much. |
sunank200
force-pushed
the
null-logical-date-for-ui-trigger
branch
from
2492b0b to
6acdf3a
Compare
sunank200
changed the title
sunank200
force-pushed
the
null-logical-date-for-ui-trigger
branch
from
d61eb63 to
c58b2c0
Compare
sunank200
force-pushed
the
null-logical-date-for-ui-trigger
branch
from
c58b2c0 to
51fd9d5
Compare
uranusjr
reviewed
Feb 10, 2025
sunank200
force-pushed
the
null-logical-date-for-ui-trigger
branch
2 times, most recently
from
9b2158e to
fd21a29
Compare
sunank200
force-pushed
the
null-logical-date-for-ui-trigger
branch
5 times, most recently
from
80238c0 to
b4e1de0
Compare
Lee-W
approved these changes
Feb 13, 2025
Member
|
opps, looks like there's conflict |
sunank200
force-pushed
the
null-logical-date-for-ui-trigger
branch
from
b4e1de0 to
b867b95
Compare
Collaborator
Author
@Lee-W fixed it |
uranusjr
reviewed
Feb 13, 2025
uranusjr
reviewed
Feb 13, 2025
uranusjr
approved these changes
Feb 13, 2025
sunank200
force-pushed
the
null-logical-date-for-ui-trigger
branch
from
187f908 to
dc18391
Compare
sunank200
force-pushed
the
null-logical-date-for-ui-trigger
branch
from
dc18391 to
a6d43c9
Compare
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…e#46512) * Add logic for if logical date null, there should be no data interval * When logical_date is None, data_interval should be None * fix the tests * fix the tests * fix the tests * fix the assignment * Fix the PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
closes: #46197
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.