-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix DbApiHook.insert_rows logging incorrect number of rows commited #45789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Lee-W
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be possible for us to add a test here?
I've added a test but I am not really sure how to run it. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…pache#45789) * Fix DbApiHook.insert_rows logging incorrect number of rows commited * add test for checking the log message matches the amount of rows committed
…pache#45789) * Fix DbApiHook.insert_rows logging incorrect number of rows commited * add test for checking the log message matches the amount of rows committed
…pache#45789) * Fix DbApiHook.insert_rows logging incorrect number of rows commited * add test for checking the log message matches the amount of rows committed
…pache#45789) * Fix DbApiHook.insert_rows logging incorrect number of rows commited * add test for checking the log message matches the amount of rows committed
…pache#45789) * Fix DbApiHook.insert_rows logging incorrect number of rows commited * add test for checking the log message matches the amount of rows committed
DbApiHook.insert_rowsis logging the incorrect number of commited rows whenexecutemanyis supported by the database.The current behavior is like this:
Since it says 'so far', logging the accumulated number of rows commited makes more sense:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.