Skip to content

Conversation

@plutaniano
Copy link
Contributor

DbApiHook.insert_rows is logging the incorrect number of commited rows when executemany is supported by the database.

The current behavior is like this:

[2025-01-19, 16:51:32 UTC] {sql.py:681} INFO - Loaded 1000 rows into postgres.public.my_table so far
[2025-01-19, 16:51:32 UTC] {sql.py:681} INFO - Loaded 1000 rows into postgres.public.my_table so far
[2025-01-19, 16:51:32 UTC] {sql.py:681} INFO - Loaded 1000 rows into postgres.public.my_table so far
[2025-01-19, 16:51:33 UTC] {sql.py:681} INFO - Loaded 1000 rows into postgres.public.my_table so far
[2025-01-19, 16:51:33 UTC] {sql.py:681} INFO - Loaded 1000 rows into postgres.public.my_table so far
[2025-01-19, 16:51:34 UTC] {sql.py:681} INFO - Loaded 1000 rows into postgres.public.my_table so far
[2025-01-19, 16:51:34 UTC] {sql.py:681} INFO - Loaded 1000 rows into postgres.public.my_table so far

Since it says 'so far', logging the accumulated number of rows commited makes more sense:

[2025-01-19, 16:51:32 UTC] {sql.py:681} INFO - Loaded 1000 rows into postgres.public.my_table so far
[2025-01-19, 16:51:32 UTC] {sql.py:681} INFO - Loaded 2000 rows into postgres.public.my_table so far
[2025-01-19, 16:51:32 UTC] {sql.py:681} INFO - Loaded 3000 rows into postgres.public.my_table so far
[2025-01-19, 16:51:33 UTC] {sql.py:681} INFO - Loaded 4000 rows into postgres.public.my_table so far
[2025-01-19, 16:51:33 UTC] {sql.py:681} INFO - Loaded 5000 rows into postgres.public.my_table so far
[2025-01-19, 16:51:34 UTC] {sql.py:681} INFO - Loaded 6000 rows into postgres.public.my_table so far
[2025-01-19, 16:51:34 UTC] {sql.py:681} INFO - Loaded 7000 rows into postgres.public.my_table so far

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 19, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible for us to add a test here?

@plutaniano
Copy link
Contributor Author

would it be possible for us to add a test here?

I've added a test but I am not really sure how to run it.

@Lee-W Lee-W merged commit 2fda2c1 into apache:main Jan 27, 2025
61 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 27, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 27, 2025
josix pushed a commit to josix/airflow that referenced this pull request Jan 27, 2025
…pache#45789)

* Fix DbApiHook.insert_rows logging incorrect number of rows commited

* add test for checking the log message matches the amount of rows committed
@plutaniano plutaniano deleted the patch-1 branch January 28, 2025 15:02
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
…pache#45789)

* Fix DbApiHook.insert_rows logging incorrect number of rows commited

* add test for checking the log message matches the amount of rows committed
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Jan 30, 2025
…pache#45789)

* Fix DbApiHook.insert_rows logging incorrect number of rows commited

* add test for checking the log message matches the amount of rows committed
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
…pache#45789)

* Fix DbApiHook.insert_rows logging incorrect number of rows commited

* add test for checking the log message matches the amount of rows committed
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
…pache#45789)

* Fix DbApiHook.insert_rows logging incorrect number of rows commited

* add test for checking the log message matches the amount of rows committed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:common-sql

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants