Skip to content

Fixing return type for azure hook 'run_query' #45470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 6 commits into from
Jan 8, 2025
Merged

Fixing return type for azure hook 'run_query' #45470

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9aa609e
Fixing return type for azure hook 'run_query'
amoghrajesh Jan 7, 2025
bd9d6ff
Attempt to fix spell-check errors in CI
jscheffl Jan 7, 2025
6ba6c3b
Another spelling attempt
jscheffl Jan 7, 2025
99090f5
Reverting...
jscheffl Jan 7, 2025
bad1a13
fixing spell check
amoghrajesh Jan 8, 2025
8cbbdcc
fixing spell check
amoghrajesh Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions providers/src/airflow/providers/microsoft/azure/hooks/adx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

.. spelling:word-list::

KustoResponseDataSetV
KustoResponseDataSet
Copy link
Contributor

@jscheffl jscheffl Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, cool did not notice and did not know that spelling wordlists can also be adjusted non-global in a py file locally...

kusto
"""

Expand All @@ -41,7 +41,7 @@
)

if TYPE_CHECKING:
from azure.kusto.data.response import KustoResponseDataSetV2
from azure.kusto.data.response import KustoResponseDataSet


class AzureDataExplorerHook(BaseHook):
Expand Down Expand Up @@ -206,11 +206,11 @@ def get_required_param(name: str) -> str:

return KustoClient(kcsb)

def run_query(self, query: str, database: str, options: dict | None = None) -> KustoResponseDataSetV2:
def run_query(self, query: str, database: str, options: dict | None = None) -> KustoResponseDataSet:
"""
Run KQL query using provided configuration, and return KustoResponseDataSet instance.

See: `azure.kusto.data.response.KustoResponseDataSet`
See: azure.kusto.data.response.KustoResponseDataSet
If query is unsuccessful AirflowException is raised.

:param query: KQL query to run
Expand Down