Fixing return type for azure hook 'run_query' #45470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
jscheffl
approved these changes
Jan 7, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Ah, this fixes https://github.com/apache/airflow/actions/runs/12652631045/job/35256276439 ? ... then I don't need to investigate in parallel... LGTM!
jscheffl
reviewed
Jan 7, 2025
jscheffl
reviewed
Jan 7, 2025
Contributor
|
Sorry for the failed attempts :-( Sometimes I hate spell-checking :-( |
jscheffl
reviewed
Jan 7, 2025
Contributor
Author
|
@jscheffl it was slightly late for me, I slept! Will check now. Thanks though |
eladkal
reviewed
Jan 8, 2025
Contributor
Author
|
@jscheffl it took me a few tries to fix spellcheck too! |
Member
|
Nice :) |
dstandish
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jan 8, 2025
jscheffl
reviewed
Jan 8, 2025
| .. spelling:word-list:: | ||
|
|
||
| KustoResponseDataSetV | ||
| KustoResponseDataSet |
Contributor
There was a problem hiding this comment.
Ah, cool did not notice and did not know that spelling wordlists can also be adjusted non-global in a py file locally...
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New release of https://github.com/Azure/azure-kusto-python couldve introduced this. Tried my hand at a fix for CI failure: https://github.com/apache/airflow/actions/runs/12652631045
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.