Remove returns in final clause of S3ToDynamoDBOperator #43456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
romsharon98
reviewed
Oct 29, 2024
providers/src/airflow/providers/amazon/aws/transfers/s3_to_dynamodb.py
Outdated
Show resolved
Hide resolved
romsharon98
approved these changes
Oct 29, 2024
romsharon98
reviewed
Oct 29, 2024
providers/src/airflow/providers/amazon/aws/transfers/s3_to_dynamodb.py
Outdated
Show resolved
Hide resolved
Co-authored-by: rom sharon <33751805+romsharon98@users.noreply.github.com>
ferruzzi
reviewed
Oct 29, 2024
providers/src/airflow/providers/amazon/aws/transfers/s3_to_dynamodb.py
Outdated
Show resolved
Hide resolved
romsharon98
approved these changes
Nov 5, 2024
topherinternational
pushed a commit
to topherinternational/airflow
that referenced
this pull request
Nov 5, 2024
* Remove returns in final clause of S3ToDynamoDBOperator * remove temp table in finally * remove duplicate log Co-authored-by: rom sharon <33751805+romsharon98@users.noreply.github.com> * remove except statement * remove test case --------- Co-authored-by: rom sharon <33751805+romsharon98@users.noreply.github.com>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Remove returns in final clause of S3ToDynamoDBOperator * remove temp table in finally * remove duplicate log Co-authored-by: rom sharon <33751805+romsharon98@users.noreply.github.com> * remove except statement * remove test case --------- Co-authored-by: rom sharon <33751805+romsharon98@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #43274
This PR will remove returns in the final clause of
S3ToDynamoDBOperator.Other related issues has been fixed by the PR: #43426
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.