return in finally can swallow exceptions

[iritkatriel]

Apache Airflow version

main (development)

If "Other Airflow 2 version" selected, which one?

No response

What happened?

In a few places in the code, you have a return statement in a finally block which would swallow any in-flight exception:

airflow/providers/src/airflow/providers/amazon/aws/hooks/athena.py

Line 165 in be55378

return state

airflow/providers/src/airflow/providers/amazon/aws/hooks/athena.py

Line 188 in be55378

return reason

airflow/providers/src/airflow/providers/amazon/aws/hooks/athena.py

Line 292 in be55378

return self.check_query_status(query_execution_id)

airflow/providers/src/airflow/providers/amazon/aws/transfers/s3_to_dynamodb.py

Line 243 in be55378

return dynamodb_hook.get_conn().Table(self.dynamodb_table_name).table_arn

This means that if an unhandled exception (like a BaseException such as KeyboardInterrupt) is raised from the try body, or any exception is raised from an except: clause, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

What you think should happen instead?

No response

How to reproduce

This is from analysis of the source code.

Operating System

All

Versions of Apache Airflow Providers

No response

Deployment

Other

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

[potiuk]

Marked it as good first issue. But It would be great - since you know already what to do - could fix it. Otherwise it will wait for someone to pick it up.

[yangyulely]

@potiuk , I would like work on this, if that's okay.

[potiuk]

Feel free!

[Rustix69]

@potiuk Can I also work on this issue ? I had found the Solution.

[potiuk]

Sure. Talk to @yangyulely and try to coordinate together.