Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename views to routes for FastAPI apps #43057

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Oct 15, 2024

This is part of the change I want to do for #43015 but going to break it down to keep it manageable.

Since these are actual routes for APIs, renaming them to routes instead of views.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes more sense indeed

This is part of the change I want to do for apache#43015 but going to break it down to keep it manageable.
@kaxil kaxil merged commit 3c3973e into apache:main Oct 15, 2024
51 checks passed
@kaxil kaxil deleted the rename-views-routes branch October 15, 2024 22:15
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
This is part of the change I want to do for apache#43015 but going to break it down to keep it manageable.

Since these are actual routes for APIs, renaming them to routes instead of views.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants