Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple "Task Execution API" server #43015

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Oct 14, 2024

closes #43009

The Task Execution API is created as a separate FastAPI APP so that it allows us to hook CLI and selectively run the "Execution API" with the rest of Airflow API (UI/public). This is so that users can scale the APIs separately if needed as mentioned in #43009

Depends on:


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@kaxil kaxil requested a review from ashb October 14, 2024 23:14
airflow/cli/cli_config.py Outdated Show resolved Hide resolved
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

airflow/cli/commands/fastapi_api_command.py Outdated Show resolved Hide resolved
airflow/api_fastapi/app.py Outdated Show resolved Hide resolved
airflow/api_fastapi/app.py Outdated Show resolved Hide resolved
@kaxil kaxil changed the title Add simple "Task API" server Add simple "Task Execution API" server Oct 15, 2024
kaxil added a commit to astronomer/airflow that referenced this pull request Oct 15, 2024
This is part of the change I want to do for apache#43015 but going to break it down to keep it manageable.
kaxil added a commit to astronomer/airflow that referenced this pull request Oct 15, 2024
This is part of the change I want to do for apache#43015 but going to break it down to keep it manageable.
kaxil added a commit to astronomer/airflow that referenced this pull request Oct 15, 2024
This is part of the change I want to do for apache#43015 but going to break it down to keep it manageable.
kaxil added a commit that referenced this pull request Oct 15, 2024
This is part of the change I want to do for #43015 but going to break it down to keep it manageable.

Since these are actual routes for APIs, renaming them to routes instead of views.
kaxil added a commit to astronomer/airflow that referenced this pull request Oct 16, 2024
In preparation for adding apache#43015, this PRs re-organizes the ``api_fastapi``. The goal will be to have
2 apps: `execution_api` (Task Execution API: AIP-72) and the `core_api` (UI and Public APi).
kaxil added a commit to astronomer/airflow that referenced this pull request Oct 16, 2024
In preparation for adding apache#43015, this PRs re-organizes the ``api_fastapi``. The goal will be to have
2 apps: `execution_api` (Task Execution API: AIP-72) and the `core_api` (UI and Public APi).
kaxil added a commit to astronomer/airflow that referenced this pull request Oct 16, 2024
In preparation for adding apache#43015, this PRs re-organizes the ``api_fastapi``. The goal will be to have
2 apps: `execution_api` (Task Execution API: AIP-72) and the `core_api` (UI and Public APi).
kaxil added a commit to astronomer/airflow that referenced this pull request Oct 16, 2024
In preparation for adding apache#43015, this PRs re-organizes the ``api_fastapi``. The goal will be to have
2 apps: `execution_api` (Task Execution API: AIP-72) and the `core_api` (UI and Public APi).
closes apache#43009

The Task Execution API is created as a separate FastAPI APP so that it allows us to hook CLI and selectively run the "Execution API" with the rest of Airflow API (UI/public). This is so that users can scale the APIs separately if needed as mentioned in apache#43009
@kaxil kaxil merged commit 9ce6d49 into apache:main Oct 17, 2024
51 checks passed
@kaxil kaxil deleted the task-api branch October 17, 2024 10:44
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
This is part of the change I want to do for apache#43015 but going to break it down to keep it manageable.

Since these are actual routes for APIs, renaming them to routes instead of views.
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
closes apache#43009

The Task Execution API is created as a separate FastAPI APP so that it allows us to hook CLI and selectively run the "Execution API" with the rest of Airflow API (UI/public). This is so that users can scale the APIs separately if needed as mentioned in apache#43009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Create simple "Task API" server based on FastAPI
4 participants