Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant scheduler_lock column from dag table #43023

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

prabhusneha
Copy link

Refer GitHub issue #42258

Remove all scheduler_lock references from the codebase.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Oct 15, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@ephraimbuddy
Copy link
Contributor

You have some conflicts. This seems like a breaking change even though the column is not used

@prabhusneha prabhusneha force-pushed the remove-column-scheduler_lock branch 3 times, most recently from 2d85a30 to 06de7f9 Compare October 17, 2024 07:09
@pierrejeambrun pierrejeambrun added the legacy api Whether legacy API changes should be allowed in PR label Oct 17, 2024
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Oct 17, 2024

Assigning label labels and restarting the CI.

@pierrejeambrun pierrejeambrun added the legacy ui Whether legacy UI change should be allowed in PR label Oct 17, 2024
@uranusjr
Copy link
Member

LGTM. When was this first added, by who, for what? (We can at least answer that with a git blame)

@@ -2819,8 +2819,6 @@ class DagModel(Base):
# Time when the DAG last received a refresh signal
# (e.g. the DAG's "refresh" button was clicked in the web UI)
last_expired = Column(UtcDateTime)
# Whether (one of) the scheduler is scheduling this DAG at the moment
scheduler_lock = Column(Boolean)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would also need a SQLAlchemy migration script generated using Alembic & kept in https://github.com/apache/airflow/tree/main/airflow/migrations/versions to drop this column, no?

Reference guide to generate the migration script: https://github.com/apache/airflow/blob/main/contributing-docs/13_metadata_database_updates.rst

cc: @ephraimbuddy

@ashb
Copy link
Member

ashb commented Oct 21, 2024

This predates airflow 2, and I don't think was ever really used for much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:CLI area:serialization area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation legacy api Whether legacy API changes should be allowed in PR legacy ui Whether legacy UI change should be allowed in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants