-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove redundant scheduler_lock column from dag table #43023
base: main
Are you sure you want to change the base?
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
You have some conflicts. This seems like a breaking change even though the column is not used |
2d85a30
to
06de7f9
Compare
Assigning |
06de7f9
to
99e34ea
Compare
LGTM. When was this first added, by who, for what? (We can at least answer that with a |
@@ -2819,8 +2819,6 @@ class DagModel(Base): | |||
# Time when the DAG last received a refresh signal | |||
# (e.g. the DAG's "refresh" button was clicked in the web UI) | |||
last_expired = Column(UtcDateTime) | |||
# Whether (one of) the scheduler is scheduling this DAG at the moment | |||
scheduler_lock = Column(Boolean) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we would also need a SQLAlchemy migration script generated using Alembic & kept in https://github.com/apache/airflow/tree/main/airflow/migrations/versions to drop this column, no?
Reference guide to generate the migration script: https://github.com/apache/airflow/blob/main/contributing-docs/13_metadata_database_updates.rst
cc: @ephraimbuddy
This predates airflow 2, and I don't think was ever really used for much |
Refer GitHub issue #42258
Remove all scheduler_lock references from the codebase.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.