Skip to content

Conversation

@spoutin
Copy link

@spoutin spoutin commented Oct 14, 2024

  • PR Add retrieve output docker swarm operator #41531 doesn't work on a mutli node environment since inspect_container from the docker sdk will not work if the docker container did run on the node which call the api. This results in a container not found error preventing the Operator from running. The code was since been removed since there is no way to guarantee the placement of the docker container.

  • adding Xcom support for docker logs. If do_xcom_push is true (default) the last line of the docker logs will be push to the xcom results. If xcom_all is set to true, all results will be push to xcom.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

do_xcom_all will return the entire output from the docker container and pass it to xcom otherwise only the last line will be returned.
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 14, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@spoutin spoutin closed this Oct 14, 2024
@spoutin spoutin reopened this Oct 14, 2024
@spoutin spoutin closed this Oct 14, 2024
@spoutin
Copy link
Author

spoutin commented Oct 14, 2024

closing since I bug, will recreate a new pull reqeust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant