-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional named parameters and job parameters support to DatabricksRunNowOperator #43004
base: main
Are you sure you want to change the base?
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing this, @pranshupand-db! A few requests before the core team reviews the PR:
- We should not add support for
sql_params
. See my inline comment for more details. - We should add support for
dbt_commands
because even though it is being deprecated along withsql_params
, usingjob_parameters
for dbt tasks is more complicated because you have to use dynamic value references so it's not a drop-in replacement. - Let's make sure documentation is present for
dbt_commands
, similar tojob_parameters
.
providers/src/airflow/providers/databricks/operators/databricks.py
Outdated
Show resolved
Hide resolved
a869dbf
to
ee72a03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small nits
providers/src/airflow/providers/databricks/operators/databricks.py
Outdated
Show resolved
Hide resolved
99e5e10
to
c4014f5
Compare
…cksRunNowOperator
…s.py Co-authored-by: Gabor Ratky <gabor.ratky@databricks.com>
DatabricksRunNowOperator
:dbt_commands
job_parameters
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.