Skip to content

Conversation

@luyangliuable
Copy link
Contributor

Screen.Recording.2024-10-08.at.12.55.23.am.mov
  • I have updated the URL to reflect changes in the dagDisplayNamePattern. If this is not desirable, I can remove it.
  • I created an enum in searchParams.ts.

There are a few issues to address:

  • The dagDisplayNamePattern does not accurately find or include the DAGs when the text matches the tag name exactly. The reason for this is unclear.
  • The spinner is not centered. I removed the conditional rendering logic for DagsList based on isLoading, as it was causing the entire DagsList component to re-render every time the data was updated.


Closes: https://github.com/apache/airflow/issues/27581

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 7, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 7, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@luyangliuable luyangliuable force-pushed the feature/search-by-dag-display-name-pattern branch from 7c82865 to 93bb123 Compare October 8, 2024 13:16
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

Also, @pierrejeambrun we might need to adjust the pattern search query, with a on the backend since I couldn't get it to work, even with curl. Looks like we might not be setting the attribute right in our search parameters class

PAUSED = "paused",
LIMIT = "limit",
OFFSET = "offset",
SORT = "sort"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to rebase again to add the last dag run state param here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi i am not sure what you mean by this one I rebased and I could not spot the last dag run param yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in DagsFilters there is now const STATE_PARAM = "last_dag_run_state";, we just need to move that param to the constant you created when you rebase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierrejeambrun
Copy link
Member

Also, @pierrejeambrun we might need to adjust the pattern search query, with a on the backend since I couldn't get it to work, even with curl. Looks like we might not be setting the attribute right in our search parameters class

Indeed something's off.

PR here #42863, let me know if this is better. (works on my end)

@bbovenzi
Copy link
Contributor

bbovenzi commented Oct 10, 2024

Looking good. Add the wildcard key, rebase and run pnpm lint:fix and we should be just about ready to merge.

@luyangliuable
Copy link
Contributor Author

Hi @bbovenzi , I rebased and created a new PR #42896 that fixed these:

  • Add the wildcard key.
  • Rebase.
  • Run pnpm lint:fix with no errors.

new PR: #42896

@bbovenzi
Copy link
Contributor

Closed in favor of #42896

@bbovenzi bbovenzi closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants