-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add search by dag_display_name_pattern on dag list page.
#42797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search by dag_display_name_pattern on dag list page.
#42797
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
7c82865 to
93bb123
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments.
Also, @pierrejeambrun we might need to adjust the pattern search query, with a on the backend since I couldn't get it to work, even with curl. Looks like we might not be setting the attribute right in our search parameters class
| PAUSED = "paused", | ||
| LIMIT = "limit", | ||
| OFFSET = "offset", | ||
| SORT = "sort" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we need to rebase again to add the last dag run state param here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi i am not sure what you mean by this one I rebased and I could not spot the last dag run param yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in DagsFilters there is now const STATE_PARAM = "last_dag_run_state";, we just need to move that param to the constant you created when you rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added on new PR: https://github.com/apache/airflow/pull/42896/files
Indeed something's off. PR here #42863, let me know if this is better. (works on my end) |
|
Looking good. Add the wildcard key, rebase and run |
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
|
Closed in favor of #42896 |
Screen.Recording.2024-10-08.at.12.55.23.am.mov
dagDisplayNamePattern. If this is not desirable, I can remove it.searchParams.ts.There are a few issues to address:
dagDisplayNamePatterndoes not accurately find or include the DAGs when the text matches the tag name exactly. The reason for this is unclear.DagsListbased onisLoading, as it was causing the entireDagsListcomponent to re-render every time the data was updated.Closes: https://github.com/apache/airflow/issues/27581