Skip to content

Adjust typing in Mongo hook to prevent mypy errors #42354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahar1 merged 1 commit into from
Sep 19, 2024
Merged

Adjust typing in Mongo hook to prevent mypy errors #42354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions airflow/providers/mongo/hooks/mongo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
if TYPE_CHECKING:
from types import TracebackType

from pymongo.collection import Collection as MongoCollection
from pymongo.command_cursor import CommandCursor
from typing_extensions import Literal

from airflow.models import Connection
Expand Down Expand Up @@ -218,9 +220,7 @@ def _create_uri(self) -> str:
path = f"/{self.connection.schema}"
return urlunsplit((scheme, netloc, path, "", ""))

def get_collection(
self, mongo_collection: str, mongo_db: str | None = None
) -> pymongo.collection.Collection:
def get_collection(self, mongo_collection: str, mongo_db: str | None = None) -> MongoCollection:
"""
Fetch a mongo collection object for querying.

Expand All @@ -233,7 +233,7 @@ def get_collection(

def aggregate(
self, mongo_collection: str, aggregate_query: list, mongo_db: str | None = None, **kwargs
) -> pymongo.command_cursor.CommandCursor:
) -> CommandCursor:
"""
Run an aggregation pipeline and returns the results.

Expand Down