Adjust typing in Mongo hook to prevent mypy errors #42354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
eladkal,
hussein-awala,
romsharon98 and
shahar1
shahar1
approved these changes
Sep 19, 2024
Contributor
shahar1
left a comment
shahar1
left a comment
There was a problem hiding this comment.
Just noticed this in another PR, good catch!
Contributor
Author
Need to run to bed, if you see it green before me, feel free to merge! |
romsharon98
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schedules tests on main are broken because of typing problems in Mongo - which actually smell like a false-positive.
This PR tries to change typing hints to prevent a failure.
See for example: https://github.com/apache/airflow/actions/runs/10947632646/job/30397028401